Skip to content

ocamlPackages: add meta.mainProgram to many packages#172228

Merged
vbgl merged 2 commits intoNixOS:masterfrom
malob:ocamlPackages-mainProgram
May 11, 2022
Merged

ocamlPackages: add meta.mainProgram to many packages#172228
vbgl merged 2 commits intoNixOS:masterfrom
malob:ocamlPackages-mainProgram

Conversation

@malob
Copy link
Copy Markdown
Member

@malob malob commented May 9, 2022

Description of changes

Continuing on my adventure to get nix run working with more packages in nixpkgs (previously #171602), I've run my hacky script on ocamlPackages.

This PR adds meta.mainProgram to all packages in ocamlPackages available for Darwin that provide a single binary whose name differs from the package's name or pname.

(While I was at it, I also ended up tweaking the order of the meta attributes to my understanding of which order is best practice.)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. label May 9, 2022
@malob
Copy link
Copy Markdown
Member Author

malob commented May 9, 2022

Result of nixpkgs-review pr 172228 run on aarch64-darwin 1

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 9, 2022
@malob malob requested a review from vbgl May 9, 2022 22:00
Copy link
Copy Markdown
Contributor

@vbgl vbgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT, this makes no harm.

@malob malob force-pushed the ocamlPackages-mainProgram branch from e2b25b1 to 8a44a41 Compare May 10, 2022 17:42
@malob malob force-pushed the ocamlPackages-mainProgram branch from 8a44a41 to 04d43a5 Compare May 10, 2022 17:45
@malob
Copy link
Copy Markdown
Member Author

malob commented May 10, 2022

Result of nixpkgs-review pr 172228 run on aarch64-darwin 1

@malob malob requested a review from vbgl May 11, 2022 00:57
@vbgl vbgl merged commit bca4ad0 into NixOS:master May 11, 2022
@malob malob deleted the ocamlPackages-mainProgram branch May 11, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants