ocamlPackages: add meta.mainProgram to many packages#172228
Merged
vbgl merged 2 commits intoNixOS:masterfrom May 11, 2022
Merged
ocamlPackages: add meta.mainProgram to many packages#172228vbgl merged 2 commits intoNixOS:masterfrom
vbgl merged 2 commits intoNixOS:masterfrom
Conversation
Member
Author
|
Result of |
vbgl
approved these changes
May 10, 2022
Contributor
vbgl
left a comment
There was a problem hiding this comment.
AFAICT, this makes no harm.
e2b25b1 to
8a44a41
Compare
8a44a41 to
04d43a5
Compare
Member
Author
|
Result of |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Continuing on my adventure to get
nix runworking with more packages innixpkgs(previously #171602), I've run my hacky script onocamlPackages.This PR adds
meta.mainProgramto all packages inocamlPackagesavailable for Darwin that provide a single binary whose name differs from the package'snameorpname.(While I was at it, I also ended up tweaking the order of the meta attributes to my understanding of which order is best practice.)
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes