treewide: add meta.mainProgram to many packages#171602
Merged
lovesegfault merged 3 commits intoNixOS:masterfrom May 6, 2022
Merged
treewide: add meta.mainProgram to many packages#171602lovesegfault merged 3 commits intoNixOS:masterfrom
lovesegfault merged 3 commits intoNixOS:masterfrom
Conversation
where a single bin is provided and someone might actually want to run it
Member
|
Result of |
lovesegfault
reviewed
May 5, 2022
8af062e to
d8da6a1
Compare
This was referenced May 6, 2022
Member
Author
|
Result of |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Following on from my efforts in #166865, I refined my hacky script and I've been able to find an additional 167 packages that provide a single binary whose name differs from the package's name in
nixpkgs(or the package'spname) and so don't work withnix run.The
mainProgramadditions in 16e15fa should be pretty boring and uncontroversial.I separated out additions of
mainProgramto files located inpkgs/development/libraries/into a separate commit (9e4be53) since a lot of these required more judgement. I think it makes sense for many of these packages to include amainProgramas they often provide a single binary utility as part of the package that folks might want to use. However, in some cases it's pretty marginal. For those cases, I looked into the functionality of the binary and what it's used for, and made a judgment call. (I did err on the side of addingmainProgramin a lot of the marginal cases since it does little to no harm, but there were many cases where I left it off since it made no sense.)Finally I made separate commit for
nimble-unwrapped(d8da6a1) since I added a newmetaattribute set since it was missing entirely.I've gone through these changes pretty carefully, but a couple more skims for others is probably in order as a sanity check.
(While I was at it, I also ended up tweaking the order of the
metaattributes to my understanding of which order is best practice, as well as updating some of the homepages and adding some when they were missing.)Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes