Skip to content

staging-next: 21.11 iteration 9 - 2022-04-07#167647

Merged
vcunat merged 110 commits intorelease-21.11from
staging-next-21.11
Apr 9, 2022
Merged

staging-next: 21.11 iteration 9 - 2022-04-07#167647
vcunat merged 110 commits intorelease-21.11from
staging-next-21.11

Conversation

@vcunat
Copy link
Copy Markdown
Member

@vcunat vcunat commented Apr 7, 2022

github-actions bot and others added 30 commits March 16, 2022 00:12
(cherry picked from commit abb6f3e)
(cherry picked from commit 9512291)
(cherry picked from commit 0ffdadc)
(cherry picked from commit 7648885)
(cherry picked from commit 8dabcce)
The argument to addNodePath previously wasn't being quoted, leading to
problems when the argument contains characters interpreted specially by
bash

(cherry picked from commit e975c56)
@vcunat vcunat requested review from FRidh and jonringer as code owners April 7, 2022 06:37
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 7, 2022
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Apr 7, 2022
r-burns and others added 2 commits April 7, 2022 11:45
@vcunat vcunat mentioned this pull request Apr 8, 2022
13 tasks
@vcunat
Copy link
Copy Markdown
Member Author

vcunat commented Apr 9, 2022

It looks quite good to me, though thousands of darwin builds are still queued: https://hydra.nixos.org/eval/1754231?compare=1753408#tabs-now-fail

In particular, this fixes known regressions of the recent zlib update.

@vcunat
Copy link
Copy Markdown
Member Author

vcunat commented Apr 9, 2022

@mweinelt: it looks like some python-related regressions are there, though probably nothing really blocking.

@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Apr 9, 2022

I've backported a few fixes for the things that looked important. Most of the things are either a) flaky (usually timing related things) b) darwin sandbox related (like wanting to access /tmp), I don't have enough in me to work through those, sorry.

@vcunat
Copy link
Copy Markdown
Member Author

vcunat commented Apr 9, 2022

@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Apr 9, 2022

Yeah, its getting signal 9, not sure why. @NixOS/darwin-maintainers

@veprbl
Copy link
Copy Markdown
Member

veprbl commented Apr 9, 2022

Deja vu in #154120

@vcunat vcunat merged commit 715dc13 into release-21.11 Apr 9, 2022
@vcunat
Copy link
Copy Markdown
Member Author

vcunat commented Apr 9, 2022

I merged. The fixes already seem to far outweigh the regressions, especially on x86_64-darwin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.