Skip to content

[Backport release-21.11] nodejs: Fix setup-hook addNodePath quoting#164727

Merged
vcunat merged 1 commit intostaging-21.11from
backport-163694-to-release-21.11
Apr 7, 2022
Merged

[Backport release-21.11] nodejs: Fix setup-hook addNodePath quoting#164727
vcunat merged 1 commit intostaging-21.11from
backport-163694-to-release-21.11

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Mar 18, 2022 •
edited by vcunat
Loading

Bot-based backport to release-21.11, triggered by a label in #163694.

  • Before merging, ensure that this backport complies with the Criteria for Backporting.
    • Even as a non-commiter, if you find that it does not comply, leave a comment.

@infinisil @github-actions
nodejs: Fix setup-hook addNodePath quoting
dcce69b 
The argument to addNodePath previously wasn't being quoted, leading to
problems when the argument contains characters interpreted specially by
bash

(cherry picked from commit e975c56)
@github-actions github-actions bot requested a review from jonringer as a code owner March 18, 2022 15:53
@github-actions github-actions bot mentioned this pull request Mar 18, 2022
Merged
2 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Mar 18, 2022
@jonringer
Copy link
Copy Markdown
Contributor

jonringer commented Mar 18, 2022

I feel like this should go into staging if it's not really affecting people right now.

@infinisil
Copy link
Copy Markdown
Member

infinisil commented Mar 18, 2022

@jonringer Why so?

@jonringer
Copy link
Copy Markdown
Contributor

jonringer commented Mar 18, 2022 •
edited
Loading

Just general build pressure on hydra. This is 500+ rebuilds pre branch. since there's a staging-next and staging-next-21.11 going on, that's 2000+ rebuilds in total. (trunk, staging-next, x2 for backports)

AFAICT, this has been broken for a while, and not super critical.

@vcunat vcunat changed the base branch from release-21.11 to staging-21.11 April 7, 2022 06:20
@vcunat vcunat merged commit f2fd032 into staging-21.11 Apr 7, 2022
@vcunat vcunat deleted the backport-163694-to-release-21.11 branch April 7, 2022 06:28
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonringer @infinisil @vcunat