nodejs: Fix setup-hook addNodePath quoting#163694
Merged
infinisil merged 1 commit intoNixOS:masterfrom Mar 16, 2022
Merged
Conversation
The argument to addNodePath previously wasn't being quoted, leading to problems when the argument contains characters interpreted specially by bash
Member
Author
|
I don't think this PR can cause problems, so I'm just going to merge it myself |
1 task
Contributor
|
Successfully created backport PR #164727 for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The argument to
addNodePathpreviously wasn't being quoted, leading to problems when the argument contains characters interpreted specially by bash, which was happening for me in a usage of npmlock2nix.Ping @svanderburg @Radvendii @0xSbock
Things done