Skip to content

nixos/logiops: init#167388

Closed
ckiee wants to merge 7 commits intoNixOS:masterfrom
ckiee:logiops-nixos
Closed

nixos/logiops: init#167388
ckiee wants to merge 7 commits intoNixOS:masterfrom
ckiee:logiops-nixos

Conversation

@ckiee
Copy link
Copy Markdown
Member

@ckiee ckiee commented Apr 5, 2022 •
edited
Loading

Description of changes

This adds a new NixOS module for logiops which you can read more about in #165936.

It depends on #208747 / #246115 (the libconfig serializer) being merged first and is in draft until that.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 5, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 5, 2022
@ckiee ckiee mentioned this pull request Apr 12, 2022
Closed
13 tasks
This was referenced Jul 27, 2022
Closed
Closed
@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Jul 28, 2022

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1036

SuperSandro2000
SuperSandro2000 reviewed Jul 28, 2022
View reviewed changes
@ckiee ckiee requested a review from SuperSandro2000 July 28, 2022 13:35
@ckiee
Copy link
Copy Markdown
Member Author

ckiee commented Jul 28, 2022

For some reason my Emacs is executing nixfmt instead of nixpkgs-fmt. Weird.

SuperSandro2000
SuperSandro2000 reviewed Jul 28, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

module LGTM, someone still needs to review the lib changes.

@ckiee
Copy link
Copy Markdown
Member Author

ckiee commented Jul 28, 2022

cc @Ma27 @lheckemann if either of you feel like reviewing

anund
anund reviewed Jul 29, 2022
View reviewed changes
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Jul 29, 2022
SuperSandro2000
SuperSandro2000 reviewed Jul 29, 2022
View reviewed changes
anund
anund reviewed Jul 30, 2022
View reviewed changes
anund
anund suggested changes Jul 30, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@anund anund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The libconfig implementation won't be good enough for users.

@ckiee ckiee force-pushed the logiops-nixos branch 2 times, most recently from 4c054ac to 82459de Compare July 30, 2022 16:41
@ckiee
Copy link
Copy Markdown
Member Author

ckiee commented Jul 31, 2022 •
edited
Loading

Oops. Put the new libconfig changes in the wrong commit.

Edit: That was perhaps my most ambitious git-fu so far, edited it all in place with a rebase, reset and stash :P

ckiee added a commit to ckiee/logiops that referenced this pull request Dec 10, 2022
@ckiee
logid: Fail on invalid Configurations
e37fb15 
NixOS will soon have a runtime test for logiops which uses an
invalid configuration as a baseline, expecting it to fail.

Silent errors are not nice for users; systemd does not inform users
of stderr messages in nominally running services.

NixOS/nixpkgs#167388
ckiee added a commit to ckiee/logiops that referenced this pull request Dec 10, 2022
@ckiee
logid: Fail on invalid Configurations
5741a9a 
NixOS will soon have a runtime test for logiops which uses an
invalid configuration as a baseline, expecting it to fail.

Silent errors are not nice for users; systemd does not inform users
of stderr messages in nominally running services.

NixOS/nixpkgs#167388
@ckiee ckiee mentioned this pull request Dec 10, 2022
Merged
@ckiee ckiee mentioned this pull request Jan 2, 2023
Closed
13 tasks
@ckiee ckiee requested a review from infinisil as a code owner January 2, 2023 13:01
@ckiee ckiee marked this pull request as draft January 2, 2023 13:01
ckiee added a commit to ckiee/logiops that referenced this pull request Jan 2, 2023
@ckiee
logid: Fail on invalid Configurations
1096680 
NixOS will soon have a runtime test for logiops which uses an
invalid configuration as a baseline, expecting it to fail.

Silent errors are not nice for users; systemd does not inform users
of stderr messages in nominally running services.

NixOS/nixpkgs#167388
@h7x4 h7x4 mentioned this pull request Jul 30, 2023
Merged
12 tasks
@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label Aug 14, 2023
h7x4 and others added 7 commits October 16, 2023 03:33
@h7x4 @ckiee
formats.libconfig: init
ef025e7 
Co-authored-by: ckie <25263210+ckiee@users.noreply.github.com>
Signed-off-by: h7x4 <h7x4@nani.wtf>
@h7x4 @ckiee
formats.libconfig: add tests
c4e13e8 
Co-authored-by: ckie <25263210+ckiee@users.noreply.github.com>
Signed-off-by: h7x4 <h7x4@nani.wtf>
@ckiee
pkgs-lib.formats: add note about missing pkgs quirk
04048cb
@ckiee
[PR dependency end]
4abbdbb
@ckiee
nixos/logiops: init
35fd7b0
@ckiee
logiops: remove reference to broken reload mechanism
46d9cbe
@ckiee
nixosTests.logiops: add
d0eb378 
There's no negative test due to runner limitations.

I tried to hack on the runner for a bit but it got out of scope and I'm
not interested in learning more Python. My 'fork' of nixpkgs has a
logiops-nixos-xtra branch for anyone interested in poking the testing
more.
@github-actions github-actions bot removed the 6.topic: lib The Nixpkgs function library label Oct 16, 2023
@ckiee
Copy link
Copy Markdown
Member Author

ckiee commented Oct 16, 2023

rebased on everything and attempted to bump logiops but it is very broken (PixlOne/logiops#409, among other possible issues) so that work is in a different branch.

@ckiee ckiee mentioned this pull request Oct 16, 2023
Open
@h7x4 h7x4 added 8.has: module (new) This PR adds a module in `nixos/` 8.has: tests This PR has tests labels Oct 23, 2023
@h7x4 h7x4 mentioned this pull request Feb 10, 2024
Open
13 tasks
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@ckiee ckiee closed this Jul 2, 2024
@ckiee ckiee mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@infinisil infinisil Awaiting requested review from infinisil

+1 more reviewer

@anund anund anund approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: tests This PR has tests 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ckiee @nixos-discourse @anund @SuperSandro2000 @wegank @h7x4