Skip to content

Revert "gmailctl: 0.10.0 -> unstable-2022-03-24"#165965

Closed
doronbehar wants to merge 1 commit intoNixOS:masterfrom
doronbehar:pkg/gmailctl
Closed

Revert "gmailctl: 0.10.0 -> unstable-2022-03-24"#165965
doronbehar wants to merge 1 commit intoNixOS:masterfrom
doronbehar:pkg/gmailctl

Conversation

@doronbehar
Copy link
Copy Markdown
Contributor

This reverts commit de5a0ee - PR #165955 .

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Copy Markdown
Member

No need to revert this.

unstable version is required because of mbrt/gmailctl#232 and mbrt/gmailctl@484bb68

@ofborg ofborg bot requested review from SuperSandro2000 and kalbasit March 27, 2022 16:38
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 27, 2022
@doronbehar
Copy link
Copy Markdown
Contributor Author

No need to revert this.

unstable version is required because of mbrt/gmailctl#232 and mbrt/gmailctl@484bb68

This is still unacceptable that you merge a PR of yours like that without waiting for approval from (active) maintainer, I was about to report you because I suspected it was an attempt to infect all Nixpkgs users of this package with malware coded into gmailctl. Never the less, please create another PR that adds a comment explaining why an unstable version is needed.

@SuperSandro2000
Copy link
Copy Markdown
Member

I was about to report you because I suspected it was an attempt to infect all Nixpkgs users of this package with malware coded into gmailctl.

I am not sure which got you thinking this could be malware.
The commit is from mbrt/gmailctl@484bb68 which is the tip of master and this is the diff mbrt/gmailctl@v0.10.0...master.

Also if I would like to introduce malware to all users I would choose a package that are more people using and do it a lot more sneaky.

But sure I can add a comment why we track unstable.

@doronbehar
Copy link
Copy Markdown
Contributor Author

I am not sure which got you thinking this could be malware.
The commit is from mbrt/gmailctl@484bb68 which is the tip of master and this is the diff mbrt/gmailctl@v0.10.0...master.

I thought this was malware before you explained why you created the PR - that's the whole point of explaining yourself, especially when a change is not trivial or common.

@doronbehar doronbehar deleted the pkg/gmailctl branch March 2, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants