Skip to content

gmailctl: 0.10.0 -> unstable-2022-03-24#165955

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SuperSandro2000:gmailctl
Mar 27, 2022
Merged

gmailctl: 0.10.0 -> unstable-2022-03-24#165955
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SuperSandro2000:gmailctl

Conversation

@SuperSandro2000
Copy link
Copy Markdown
Member

@SuperSandro2000 SuperSandro2000 commented Mar 27, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from doronbehar and kalbasit March 27, 2022 15:10
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 27, 2022
@SuperSandro2000 SuperSandro2000 merged commit 15ee706 into NixOS:master Mar 27, 2022
@SuperSandro2000 SuperSandro2000 deleted the gmailctl branch March 27, 2022 15:42
@doronbehar doronbehar mentioned this pull request Mar 27, 2022
Closed
13 tasks
@doronbehar
Copy link
Copy Markdown
Contributor

doronbehar commented Mar 27, 2022

It'd have been nice if you could have waited more then 32 minutes from the time evaluation finished, to the time you merged. Not to mention the fact that there is no explanation either in the commit message or the PR message for why nixpkgs needs the unstable version. Reverting: #165965 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doronbehar doronbehar Awaiting requested review from doronbehar

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SuperSandro2000 @doronbehar