Skip to content

correct license on arm-trusted-firmware due to binary blob, closes #148890#158309

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

correct license on arm-trusted-firmware due to binary blob, closes #148890#158309
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Feb 6, 2022 •
edited by ghost
Loading

Please see #148890 for an explanation of the problem.

I am submitting TWO PRs to close this issue; you may merge either one of them (it is not necessary to merge both)

Motivation for this change

See #148890

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 6, 2022
@lukegb
Copy link
Copy Markdown
Contributor

lukegb commented Feb 7, 2022

For the record, the counterpart PR is #158310. Going to add to the discussion under #148890 rather than here, though, since it's more general about the philosophical change here.

@lukegb lukegb mentioned this pull request Feb 7, 2022
Merged
13 tasks
@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 7, 2022 •
edited by ghost
Loading

the philosophical change here

It isn't a philosophical change; it corrects an oversight to bring licensing in line with longstanding policy.

I was very surprised to find CPU binaries without source code in a nixpkgs package whose license claimed unfree=false. I think most people would be. Otherwise what's the point? The current licensing for this package is inconsistent with pkgs/os-specific/linux/nvidia-x11/default.nix.

@ghost ghost mentioned this pull request Feb 8, 2022
Closed
@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 8, 2022 •
edited by ghost
Loading

Closing this in favor of #158310, which now gives the best of both worlds.

@ghost ghost closed this Feb 8, 2022
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
@ghost ghost deleted the close-148890-by-changing-license branch January 23, 2024 06:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukegb @Janik-Haag