Skip to content

armTrustedFirmwareRK3399 (misc/arm-trusted-firmware/default.nix): incorrect license, should be unfreeRedistributable #148890

@ghost

Description

Describe the bug

arm-trusted-firmware has the wrong license when built for RK3399.

This file is a binary with no source code. This is not peripheral firmware (lib.licenses.unfreeRedistributableFirmware) -- the binary file in this package is code that runs on the main CPU (at a privilege level even higher than the kernel or hypervisor!).

Although the name implies that it ostensibly has something to do with HDCP, there is no way to verify that it does not perform other functions. It is also impossible to audit it for security to ensure that it cannot be exploited. Remember, this code runs on the main CPU in EL3, above the kernel.

One possible resolution is to excise the blob from the firmware, like vinceb does in this patch

Steps To Reproduce

Steps to reproduce the behavior:

nix-env -iA armTrustedFirmwareRK3399

Metadata

Metadata

Assignees

No one assigned

    Labels

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions