Skip to content

python2.pkgs: move expressions into python2-modules/ folder#155185

Merged
FRidh merged 7 commits intoNixOS:masterfrom
FRidh:python2-cleanup
Jan 16, 2022
Merged

python2.pkgs: move expressions into python2-modules/ folder#155185
FRidh merged 7 commits intoNixOS:masterfrom
FRidh:python2-cleanup

Conversation

@FRidh
Copy link
Copy Markdown
Member

@FRidh FRidh commented Jan 16, 2022 •
edited
Loading

Another step in further separating python2 from python3.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@FRidh FRidh requested a review from mweinelt January 16, 2022 06:39
@FRidh FRidh requested a review from jonringer as a code owner January 16, 2022 06:39
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 16, 2022
@FRidh FRidh force-pushed the python2-cleanup branch 3 times, most recently from e5d2cc0 to 6ae065e Compare January 16, 2022 06:54
@FRidh FRidh mentioned this pull request Jan 16, 2022
Merged
13 tasks
@FRidh FRidh added the 8.has: clean-up This PR removes packages or removes other cruft label Jan 16, 2022
@FRidh FRidh force-pushed the python2-cleanup branch 3 times, most recently from fad4026 to f844964 Compare January 16, 2022 07:34
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 16, 2022
@FRidh
alot: application instead of python library
0225de5 
This also allows us to move notmuch2 out of python-packages.nix.
@ofborg ofborg bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 16, 2022
FRidh added 6 commits January 16, 2022 09:32
@FRidh
python2.pkgs: move expressions into python2-modules/ folder
4165a3e 
Another step in further separating python2 from python3.
@FRidh
python-modules: remove unused secretstorage/2.nix
00debf8
@FRidh
python36Packages.ipython: remove
c476698 
since python36 is no longer part of nixpkgs.
@FRidh
python3Packages.pytest_5: remove
1d99ca4 
no longer needed
@FRidh
python3Packages.graph-tool: rename file
14eddf2 
to use default.nix as is commonly done.
@FRidh
timeline: use newer wxPython
b3c2880 
since the issue was resolved
@ofborg ofborg bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Jan 16, 2022
@FRidh FRidh merged commit 6652fef into NixOS:master Jan 16, 2022
@aanderse aanderse mentioned this pull request Feb 1, 2022
Closed
13 tasks
zombiezen added a commit to zombiezen/nixpkgs that referenced this pull request Feb 3, 2022
@zombiezen
python2.pkgs.cryptography: move patch to python2-modules/ folder
21b32e0 
Missed in NixOS#155185
@Sigmanificient Sigmanificient mentioned this pull request Jan 14, 2026
Open
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt Awaiting requested review from mweinelt

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@FRidh