gnomeExtensions.pop-shell: init#147542
Merged
piegamesde merged 1 commit intoNixOS:masterfrom Dec 1, 2021
Merged
Conversation
47d25c7 to
ec85d9c
Compare
ec85d9c to
b3748ea
Compare
piegamesde
requested changes
Nov 29, 2021
Member
piegamesde
left a comment
There was a problem hiding this comment.
I can't judge for the patch in detail, but looks rather sane to me.
b3748ea to
753c1f5
Compare
Contributor
Author
|
It is the same, just with current commit id / rev -> i could not wait, till one of the other one is maintained (and merged). |
This was referenced Dec 2, 2021
Contributor
|
Thanks for this! Testing it out, it all seems to work, however the default keybindings seem to be missing for a bunch of things (like super-m for maximize). Seems like scripts/configure.sh needs to be run as well, or something like it. |
12 tasks
|
@jsravn I set them up manually using home-manager's dconf module (they also include some tweaks): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
solve #104160, #102150 and a part of #144411
thanks @Enzime - sorry i could not wait and publish this part already in this PR.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes