gnome-shell-extension-pop-shell: init at 1.0.0#102150
gnome-shell-extension-pop-shell: init at 1.0.0#102150Synthetica9 wants to merge 1 commit intoNixOS:masterfrom
Conversation
worldofpeace
left a comment
There was a problem hiding this comment.
Commit message should have init at not @
The commit message already had that, it was only the pr title that didn't. Changed it |
SuperSandro2000
left a comment
There was a problem hiding this comment.
Can you please squash the commits together?
SuperSandro2000
left a comment
There was a problem hiding this comment.
please fix the eval error.
8ab63a9 to
63e4d1e
Compare
63e4d1e to
fcf0662
Compare
|
@grahamc Wait, there was already a PR. Anyways; these are the extensions they use. I updated them to the latest version but can't test that atm since I don't have a Gnome setup (same reason I removed myself as maintainer). |
| license = licenses.gpl3; | ||
| maintainers = with maintainers; [ ]; |
There was a problem hiding this comment.
gpl3Only or gpl3Plus? Maintainer needs to be set.
|
|
||
| postInstall = '' | ||
| mv $out/usr/* $out | ||
| rmdir $out/usr |
There was a problem hiding this comment.
if you add makeFlags = [ "XDG_DATA_HOME=$(out)/share" ]; you don't need to move the files
|
I marked this as stale due to inactivity. → More info |
|
Solved in #147542 - i believe we could close this PR now. |
Great to hear, but I don't currently use Gnome. Thanks for picking this up though! |
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)