ghc on musl: Crude hack to allow integer-simple#138429
ghc on musl: Crude hack to allow integer-simple#138429nomeata wants to merge 2 commits intoNixOS:masterfrom
Conversation
as per discussion on NixOS#130441 (comment) this seems to be enough to make ``` nix-build -A pkgsMusl.haskell.packages.integer-simple.ghc884.hello ``` work again. This is likely not the right patch (maybe `gmp` should be `nativeBuildInput`? Or a propagated build input from the boot ghc?), but this way I we can discuss (and I can pull the patch into my project...)
…sl-integer-simple
|
@ofborg build pkgsMusl.haskell.packages.integer-simple.ghc884.hello pkgsMusl.haskell.packages.integer-simple.ghc8107.hello |
pulling in NixOS/nixpkgs#138429
|
cc @nh2 about this as well |
|
Answering #130441 (comment)
Based on my write-up #130441 (comment) just now, this PR is probably not the "proper fix". It is That said, It would be very beneficial though to check that |
|
I have put out an alternative PR #138524, which switches If it works, that should be cleaner than this workaround. |
|
Thanks for your help! I’ll close this then |
* Experiment: Bump nixpkgs to latest master This is to see if there are problems coming up. Some of the things in nix/haskell-packages.nix can probably be cleaned up now. Originally https://github.com/dfinity-lab/ic-ref/commit/dce1286a900525607fcc21171b82940e3ec3385f * Bump again Originally https://github.com/dfinity-lab/ic-ref/commit/b43f83609fd3a99e0a8ecd8700f4baee0c53b863 * Bump once more Originally https://github.com/dfinity-lab/ic-ref/commit/a0746ed7be49c8f1619e5b75ba84d5c832730cf8 * Fix merge issue * Fix path * Back to master * Try winter master * Remove many haskell package changes * More simplification and upstream cache use * Update freeze file * Less versionoverrides needed * Remove nix/haskell-packages, more DNRY * Fix patch handling * Add .gitattributes to mark generated files as such * s/ / / * Run github actions with ghc-8.10.7 * Fix docs jobs * Fix docs jobs some more * Update cabal.project * Bump candid some more * Checkout before setting up the cache * Fix cabal keys * Don’t set active-repositories in freeze file * Rename workflow * naersk changed it seems * Try pkgsStatic, not pkgsMusl as the latter doesn’t seem to work any more since NixOS/nixpkgs#130441 * Fix static cborg build * Try static-haskell-nix * Revert "Try static-haskell-nix" This reverts commit b375ad4. * Revert "Try pkgsStatic, not pkgsMusl" This reverts commit d1f64f1. * Try pkgsMusl again pulling in NixOS/nixpkgs#138429 * Update freeze file * Right GHC version * Try NixOS/nixpkgs#138524
as per discussion on
#130441 (comment) this
seems to be enough to make
work again.
This is likely not the right patch (maybe
gmpshould benativeBuildInput? Or a propagated build input from the boot ghc?), butthis way I we can discuss (and I can pull the patch into my project...)