Skip to content

iasl: drop package#133120

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
kidonng:iasl
Aug 10, 2021
Merged

iasl: drop package#133120
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
kidonng:iasl

Conversation

@kidonng
Copy link
Copy Markdown
Member

@kidonng kidonng commented Aug 8, 2021

Motivation for this change

A retry of #101821

Replace all instances of iasl with acpica-tools, and additionally:

  • Remove it from edk2's deps since it isn't used

  • Revert 59ab29f due to the note:

    This should be removed again when updating virtualbox to 6.1.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 8, 2021
@r-rmcgibbo
Copy link
Copy Markdown

r-rmcgibbo commented Aug 8, 2021 •
edited
Loading

Result of nixpkgs-review pr 133120 at bd5d8cee run on aarch64-linux 1

8 packages marked as broken and skipped:
  • OVMF-CSM
  • coreboot-utils
  • libvmi
  • qemu_xen
  • qemu_xen-light
  • qemu_xen_4_10
  • qemu_xen_4_10-light
  • qubes-core-vchan-xen
5 packages built successfully:
  • OVMF
  • OVMF-secureBoot
  • acpica-tools
  • acpidump-all
  • fwts
2 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/tools/misc/coreboot-utils/default.nix:92:7:

       |
92 |       installPhase = "install -Dm755 acpidump-all $out/bin/acpidump-all";
   |       ^
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/tools/misc/coreboot-utils/default.nix:9:5:

      |
9 |     license = licenses.gpl2;
  |     ^

Result of nixpkgs-review pr 133120 at bd5d8cee run on x86_64-linux 1

2 packages marked as broken and skipped:
  • linuxPackages_hardkernel_4_14.virtualbox
  • linuxPackages_hardkernel_latest.virtualbox
7 packages skipped due to time constraints:
  • linuxPackages-libre.virtualbox
  • linuxPackages_latest-libre.virtualbox
  • linuxPackages_xanmod.virtualbox
  • qemu_xen (qemu_xen_4_10)
  • virtualbox
  • virtualboxHeadless
  • virtualboxWithExtpack
28 packages built successfully:
  • OVMF
  • OVMF-CSM
  • OVMF-secureBoot
  • acpica-tools
  • acpidump-all
  • coreboot-utils
  • fwts
  • libvmi
  • linuxPackages.virtualbox (linuxPackages_5_10.virtualbox)
  • linuxPackages_4_14.virtualbox
  • linuxPackages_4_19.virtualbox
  • linuxPackages_4_4.virtualbox
  • linuxPackages_4_9.virtualbox
  • linuxPackages_5_12.virtualbox
  • linuxPackages_5_13.virtualbox (linuxPackages_latest.virtualbox)
  • linuxPackages_5_4.virtualbox
  • linuxPackages_hardened.virtualbox
  • linuxPackages_latest_hardened.virtualbox
  • linuxPackages_lqx.virtualbox
  • linuxPackages_testing_bcachefs.virtualbox
  • linuxPackages_zen.virtualbox
  • qemu_xen-light (qemu_xen_4_10-light)
  • qubes-core-vchan-xen
  • seabios
  • virtualboxHardened
  • xen (xenPackages.xen-vanilla ,xenPackages.xen_4_10-vanilla ,xen_4_10)
  • xen-light (xenPackages.xen-light ,xenPackages.xen_4_10-light ,xen_4_10-light)
  • xen-slim (xenPackages.xen-slim ,xenPackages.xen_4_10-slim ,xen_4_10-slim)
31 suggestions:
  • warning: build-tools-in-build-inputs

    bc is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/development/compilers/edk2/default.nix:76:7:

       |
76 |       buildInputs = [ bc pythonEnv ] ++ attrs.buildInputs or [];
   |       ^
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/virtualization/seabios/default.nix:32:3:

       |
32 |   installPhase = ''
   |   ^
  • warning: build-tools-in-build-inputs

    python2.pkgs.wrapPython is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/applications/virtualization/xen/generic.nix:70:3:

       |
70 |   buildInputs = [
   |   ^
  • error: no-flags-spaces

    makeFlags cannot contain spaces, please use makeFlagsArray in Bash.

    Near pkgs/applications/virtualization/xen/generic.nix:209:3:

        |
209 |   makeFlags = [ "PREFIX=$(out) CONFIG_DIR=/etc" "XEN_SCRIPT_DIR=/etc/xen/scripts" ]
    |   ^
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/applications/virtualization/xen/generic.nix:139:5:

        |
139 |     ./0005-makefile-fix-efi-mountdir-use.patch
    |     ^
  • warning: unclear-gpl

    lgpl3 is a deprecated license, please check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.

    Near pkgs/applications/virtualization/seabios/default.nix:45:5:

       |
45 |     license = licenses.lgpl3;
   |     ^
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/tools/misc/coreboot-utils/default.nix:92:7:

       |
92 |       installPhase = "install -Dm755 acpidump-all $out/bin/acpidump-all";
   |       ^
  • warning: build-tools-in-build-inputs

    util-linux is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/development/compilers/edk2/default.nix:76:7:

       |
76 |       buildInputs = [ bc pythonEnv ] ++ attrs.buildInputs or [];
   |       ^
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/applications/virtualization/xen/generic.nix:256:5:

        |
256 |     license = lib.licenses.gpl2;
    |     ^
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/applications/virtualization/xen/generic.nix:138:5:

        |
138 |     ./0004-makefile-use-efi-ld.patch
    |     ^
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/applications/virtualization/OVMF/default.nix:61:3:

       |
61 |   meta = {
   |   ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern 'SBINDIR="/nix/store/yz5lbwpjy5188df4rzn3wwqpa9sirfl8-xen-4.10.4/sbin"' doesn't match anything in file '/nix/store/yz5lbwpjy5188df4rzn3wwqpa9sirfl8-xen-4.10.4/etc/xen/scripts/hotplugpath.sh'
    Near pkgs/applications/virtualization/xen/generic.nix:248:0:

        |
248 |     description = "Xen hypervisor and related components"
    | ^
  • warning: build-tools-in-build-inputs

    which is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/applications/virtualization/xen/generic.nix:70:3:

       |
70 |   buildInputs = [
   |   ^
  • warning: build-tools-in-build-inputs

    cmake is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/applications/virtualization/xen/generic.nix:70:3:

       |
70 |   buildInputs = [
   |   ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/usr/include/curses.h' doesn't match anything in file 'tools/xenstat/Makefile'
    Near pkgs/applications/virtualization/xen/generic.nix:248:0:

        |
248 |     description = "Xen hypervisor and related components"
    | ^
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/virtualization/xen/generic.nix:220:3:

        |
220 |   installPhase = ''
    |   ^
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/tools/misc/coreboot-utils/default.nix:9:5:

      |
9 |     license = licenses.gpl2;
  |     ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern 'SBINDIR="/nix/store/3n8hzckx9pj9zgmridw0zk3gzcdxr1yw-xen-4.10.4/sbin"' doesn't match anything in file '/nix/store/3n8hzckx9pj9zgmridw0zk3gzcdxr1yw-xen-4.10.4/etc/xen/scripts/hotplugpath.sh'
    Near pkgs/applications/virtualization/xen/generic.nix:248:0:

        |
248 |     description = "Xen hypervisor and related components"
    | ^
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/os-specific/linux/fwts/default.nix:29:5:

       |
29 |     license = licenses.gpl2;
   |     ^
  • warning: build-tools-in-build-inputs

    bison is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/os-specific/linux/fwts/default.nix:15:3:

       |
15 |   buildInputs = [ glib pcre json_c flex bison dtc pciutils dmidecode acpica-tools libbsd ];
   |   ^
  • warning: build-tools-in-build-inputs

    flex is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/applications/virtualization/xen/generic.nix:70:3:

       |
70 |   buildInputs = [
   |   ^
  • error: no-flags-spaces

    buildFlags cannot contain spaces, please use buildFlagsArray in Bash.

    Near pkgs/applications/virtualization/OVMF/default.nix:32:3:

       |
32 |   buildFlags =
   |   ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/usr' doesn't match anything in file 'tools/libfsimage/common/fsimage_plugin.c'
    Near pkgs/applications/virtualization/xen/generic.nix:248:0:

        |
248 |     description = "Xen hypervisor and related components"
    | ^
  • warning: name-and-version

    Did you mean to pass pname instead of name to mkDerivation?

    Near pkgs/applications/virtualization/xen/generic.nix:63:3:

       |
63 |   name = "xen-${version}";
   |   ^

    Near pkgs/applications/virtualization/xen/4.10.nix:41:3:

       |
41 |   version = "4.10.4";
   |   ^
  • warning: build-tools-in-build-inputs

    flex is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/os-specific/linux/fwts/default.nix:15:3:

       |
15 |   buildInputs = [ glib pcre json_c flex bison dtc pciutils dmidecode acpica-tools libbsd ];
   |   ^
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/applications/virtualization/xen/generic.nix:136:5:

        |
136 |     ./0000-fix-ipxe-src.patch
    |     ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '$(CC) $(CFLAGS) -v' doesn't match anything in file 'xen/Makefile'
    Near pkgs/applications/virtualization/xen/generic.nix:248:0:

        |
248 |     description = "Xen hypervisor and related components"
    | ^
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/applications/virtualization/xen/generic.nix:137:5:

        |
137 |     ./0000-fix-install-python.patch
    |     ^
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/applications/virtualization/seabios/default.nix:21:3:

       |
21 |   configurePhase = ''
   |   ^
  • warning: build-tools-in-build-inputs

    pandoc is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/applications/virtualization/xen/generic.nix:70:3:

       |
70 |   buildInputs = [
   |   ^
  • warning: build-tools-in-build-inputs

    bison is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/applications/virtualization/xen/generic.nix:70:3:

       |
70 |   buildInputs = [
   |   ^

@SuperSandro2000 SuperSandro2000 changed the title iasl: drop pacakge iasl: drop package Aug 8, 2021
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 8, 2021
@SuperSandro2000
Copy link
Copy Markdown
Member

SuperSandro2000 commented Aug 8, 2021

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 133120 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • linuxPackages-libre.virtualbox
  • linuxPackages_hardkernel_4_14.virtualbox
  • linuxPackages_hardkernel_latest.virtualbox
  • linuxPackages_latest-libre.virtualbox
33 packages built:
  • OVMF
  • OVMF-CSM
  • OVMF-secureBoot
  • acpica-tools
  • acpidump-all
  • coreboot-utils
  • fwts
  • libvmi
  • linuxPackages.virtualbox (linuxPackages_5_10.virtualbox)
  • linuxPackages_4_14.virtualbox
  • linuxPackages_4_19.virtualbox
  • linuxPackages_4_4.virtualbox
  • linuxPackages_4_9.virtualbox
  • linuxPackages_5_12.virtualbox
  • linuxPackages_5_13.virtualbox (linuxPackages_latest.virtualbox)
  • linuxPackages_5_4.virtualbox
  • linuxPackages_hardened.virtualbox
  • linuxPackages_latest_hardened.virtualbox
  • linuxPackages_lqx.virtualbox
  • linuxPackages_testing_bcachefs.virtualbox
  • linuxPackages_xanmod.virtualbox
  • linuxPackages_zen.virtualbox
  • qemu_xen (qemu_xen_4_10)
  • qemu_xen-light (qemu_xen_4_10-light)
  • qubes-core-vchan-xen
  • seabios
  • virtualbox
  • virtualboxHardened
  • virtualboxHeadless
  • virtualboxWithExtpack
  • xen (xenPackages.xen-vanilla ,xenPackages.xen_4_10-vanilla ,xen_4_10)
  • xen-light (xenPackages.xen-light ,xenPackages.xen_4_10-light ,xen_4_10-light)
  • xen-slim (xenPackages.xen-slim ,xenPackages.xen_4_10-slim ,xen_4_10-slim)

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 8, 2021
@kidonng kidonng force-pushed the iasl branch 3 times, most recently from 00cb0a2 to 98b946a Compare August 10, 2021 03:44
@SuperSandro2000 SuperSandro2000 merged commit b17e970 into NixOS:master Aug 10, 2021
@kidonng kidonng deleted the iasl branch August 10, 2021 10:39
danc86 added a commit to danc86/lx2k-nix that referenced this pull request Jul 11, 2022
@danc86
iasl -> acpica-tools
b1c94f8 
The iasl package was dropped from nixpkgs in:
NixOS/nixpkgs#133120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kidonng @r-rmcgibbo @SuperSandro2000