Skip to content

p4: 2020.1.2007551 -> 2020.1.2156517#131292

Closed
alex-ameen wants to merge 1 commit intoNixOS:masterfrom
alex-ameen:update_p4
Closed

p4: 2020.1.2007551 -> 2020.1.2156517#131292
alex-ameen wants to merge 1 commit intoNixOS:masterfrom
alex-ameen:update_p4

Conversation

@alex-ameen
Copy link
Copy Markdown
Contributor

@alex-ameen alex-ameen commented Jul 24, 2021

Motivation for this change

Update P4 to latest. Unfortunately without a mirror it is necessary to update our package's revision version and SHA periodically, since perforce only makes the latest tarball available at a single URL.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from corngood July 24, 2021 00:43
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 24, 2021
SuperSandro2000
SuperSandro2000 reviewed Jul 24, 2021
View reviewed changes
pkgs/applications/version-management/p4/default.nix
version = "2020.1.2156517";

src = fetchurl {
url = "https://cdist2.perforce.com/perforce/r20.1/bin.linux26x86_64/helix-core-server.tgz";
Copy link
Copy Markdown
Member

@SuperSandro2000 SuperSandro2000 Jul 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please upload this to web.archive.org.

@r-rmcgibbo
Copy link
Copy Markdown

r-rmcgibbo commented Jul 25, 2021

Result of nixpkgs-review pr 131292 at 54d3408 run on x86_64-linux 1

1 package built successfully:
  • p4
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/version-management/p4/default.nix:18:3:

       |
18 |   installPhase = ''
   |   ^

@corngood corngood mentioned this pull request Sep 10, 2021
Merged
10 tasks
@Artturin Artturin added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 13, 2022
@applePrincess applePrincess added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 17, 2022
@wegank
Copy link
Copy Markdown
Member

wegank commented Nov 4, 2022

Closed by #152439.

@wegank wegank closed this Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@corngood corngood corngood approved these changes

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@alex-ameen @r-rmcgibbo @wegank @corngood @SuperSandro2000 @applePrincess @Artturin