Skip to content

p4: 2020.1.2007551 -> 2021.2.220112#152439

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
Mic92:p4
Dec 31, 2021
Merged

p4: 2020.1.2007551 -> 2021.2.220112#152439
Mic92 merged 1 commit intoNixOS:masterfrom
Mic92:p4

Conversation

@Mic92
Copy link
Copy Markdown
Member

@Mic92 Mic92 commented Dec 28, 2021

Motivation for this change

saw a 404 when reviewing #149731

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from corngood December 28, 2021 10:25
@corngood
Copy link
Copy Markdown
Contributor

@Mic92 these links will keep breaking. I'd suggest using something like archive.org as in #110168.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 29, 2021
@Mic92
Copy link
Copy Markdown
Member Author

Mic92 commented Dec 30, 2021

done.

@corngood
Copy link
Copy Markdown
Contributor

All the other uses of archive.org seem to use a url like:

http://web.archive.org/web/20211118024943/https://cdist2.perforce.com/perforce/r21.2/bin.linux26x86_64/helix-core-server.tgz

I think that would be preferable, as it makes it clear when and where it was captured from.

@Mic92
Copy link
Copy Markdown
Member Author

Mic92 commented Dec 30, 2021

done.

Copy link
Copy Markdown
Contributor

@corngood corngood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@Mic92 Mic92 merged commit 77b45a1 into NixOS:master Dec 31, 2021
@Mic92 Mic92 deleted the p4 branch December 31, 2021 15:04
@wegank wegank mentioned this pull request Nov 4, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants