Skip to content

Agda: mark packages as broken until 2.6.2 compatible release is made#131245

Closed
alexarice wants to merge 1 commit intoNixOS:haskell-updatesfrom
alexarice:agda-broken
Closed

Agda: mark packages as broken until 2.6.2 compatible release is made#131245
alexarice wants to merge 1 commit intoNixOS:haskell-updatesfrom
alexarice:agda-broken

Conversation

@alexarice
Copy link
Copy Markdown
Contributor

Motivation for this change

Agda 2.6.2 released which broke most agda packages. Until these release a compatible release they should be marked as broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@cdepillabout @turion

@github-actions github-actions bot added the 6.topic: agda A dependently typed programming language / interactive theorem prover label Jul 23, 2021
@alexarice
Copy link
Copy Markdown
Contributor Author

Some things are currently being fixed on master, so this could cause merge conflicts, not sure how you want to proceed

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 23, 2021
@sternenseemann
Copy link
Copy Markdown
Member

Some things are currently being fixed on master, so this could cause merge conflicts, not sure how you want to proceed

Fixed on master how? We don't have the newer Agda merged yet? Are these changes backwards compatible?

Nevertheless master is merged into haskell-updates once per day, so we'll profit from the fixes on master as well.

@alexarice
Copy link
Copy Markdown
Contributor Author

Some things are currently being fixed on master, so this could cause merge conflicts, not sure how you want to proceed

Fixed on master how? We don't have the newer Agda merged yet? Are these changes backwards compatible?

Nevertheless master is merged into haskell-updates once per day, so we'll profit from the fixes on master as well.

I'm not actually sure but see #131149 for example

Comment on lines +26 to +27
# Remove if a version compatible with agda 2.6.2 is made
broken = true;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubical has been fixed and the fix has been merged into haskell-updates.

Suggested change
# Remove if a version compatible with agda 2.6.2 is made
broken = true;

@sternenseemann
Copy link
Copy Markdown
Member

Cherry-picked as 9d48670.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: agda A dependently typed programming language / interactive theorem prover 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants