Skip to content

haskellPackages.xmonad-wallpaper: remove jailbreak#128066

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
tbidne:haskell-updates
Jun 25, 2021
Merged

haskellPackages.xmonad-wallpaper: remove jailbreak#128066
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
tbidne:haskell-updates

Conversation

@tbidne
Copy link
Copy Markdown
Contributor

@tbidne tbidne commented Jun 25, 2021 •
edited
Loading

Motivation for this change

Follow-up to #127021. The upstream issue for xmonad-wallpaper has been fixed, so the jailbreak is no longer necessary: yeyan/xmonad-wallpaper/issues/2

Things done

I have tested with nix-build --no-out-link -A haskellPackages.xmonad-wallpaper. Thanks!

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tbidne
haskellPackages.xmonad-wallpaper: remove jailbreak
4d5ef43 
Removing jailbreak as upstream issue has been fixed:

yeyan/xmonad-wallpaper#2
@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Jun 25, 2021
@cdepillabout
Copy link
Copy Markdown
Member

cdepillabout commented Jun 25, 2021

@GrahamcOfBorg build haskellPackages.xmonad-wallpaper

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 25, 2021
@cdepillabout
Copy link
Copy Markdown
Member

cdepillabout commented Jun 25, 2021

Great, this built on all platforms. Thanks for following-up on this!

@cdepillabout cdepillabout merged commit 9d333df into NixOS:haskell-updates Jun 25, 2021
@tbidne
Copy link
Copy Markdown
Contributor Author

tbidne commented Jun 25, 2021

No problem, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@expipiplus1 expipiplus1 Awaiting requested review from expipiplus1

@maralorn maralorn Awaiting requested review from maralorn

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tbidne @cdepillabout