Skip to content

haskellPackages.xmonad-wallpaper: jailbreak#127021

Closed
tbidne wants to merge 1 commit intoNixOS:haskell-updatesfrom
tbidne:haskell-updates
Closed

haskellPackages.xmonad-wallpaper: jailbreak#127021
tbidne wants to merge 1 commit intoNixOS:haskell-updatesfrom
tbidne:haskell-updates

Conversation

@tbidne
Copy link
Copy Markdown
Contributor

@tbidne tbidne commented Jun 16, 2021

Motivation for this change

On 2021-06-10, stackage bumped the random library from 1.1 to 1.2.0. Unfortunately this breaks xmonad-wallpaper, as that library has a bound limit of random >=1.1 && <1.2.

Things done

Fortunately, xmonad-wallpaper builds just fine with random-1.2.0. I have tested building the package both by editing the cabal file directly and with my changes here via:

nix-build --no-out-link A haskellPackages.xmonad-wallpaper --arg config '{ allowBroken = true; }'

I'm currently attempting to rebuild my system with my version of nixpkgs, but this takes a very long time 😉. Previously my builds failed in under a minute due to the error:

Setup: Encountered missing or private dependencies:
random ==1.1.*

So this looks promising to me.

I contacted xmonad-wallpaper's maintainer about increasing the bound on hackage, as that's probably the right thing to do and would make this whole exercise unnecessary. Still, I made this PR in case we want to provide a quicker workaround (it would at least be useful for me, as I can't update nixpkgs until this is fixed). But I will, of course, defer to whatever the reviewers think is the best course of action. If this fix is merged, I can make a second PR once the package on hackage is updated.

Thanks!

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Compiles with random 1.2.0, but bound is too strict at <1.2.
@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Jun 16, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 16, 2021
@tbidne
Copy link
Copy Markdown
Contributor Author

tbidne commented Jun 16, 2021

Update: The maintainer responded and is going to try to fix this upstream. So perhaps this PR was a bit hasty 🙂. I will update with any developments here.

@sternenseemann
Copy link
Copy Markdown
Member

If you link the upstream issue in a comment, we can still intermediately merge this PR as a workaround until a new release is on hackage.

@tbidne
Copy link
Copy Markdown
Contributor Author

tbidne commented Jun 16, 2021

Thanks for the suggestion @sternenseemann. I didn't see a link to the repo on hackage, and it totally slipped my mind to look for it manually. Issue here: yeyan/xmonad-wallpaper/issues/2.

@sternenseemann
Copy link
Copy Markdown
Member

sternenseemann commented Jun 16, 2021

Cherry-picked as faa7f48140f, should be merged into master soon.

@tbidne
Copy link
Copy Markdown
Contributor Author

tbidne commented Jun 16, 2021

Thank you!

@tbidne tbidne deleted the haskell-updates branch June 16, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants