haskellPackages.xmonad-wallpaper: jailbreak#127021
Closed
tbidne wants to merge 1 commit intoNixOS:haskell-updatesfrom
Closed
haskellPackages.xmonad-wallpaper: jailbreak#127021tbidne wants to merge 1 commit intoNixOS:haskell-updatesfrom
tbidne wants to merge 1 commit intoNixOS:haskell-updatesfrom
Conversation
Compiles with random 1.2.0, but bound is too strict at <1.2.
Contributor
Author
|
Update: The maintainer responded and is going to try to fix this upstream. So perhaps this PR was a bit hasty 🙂. I will update with any developments here. |
Member
|
If you link the upstream issue in a comment, we can still intermediately merge this PR as a workaround until a new release is on hackage. |
Contributor
Author
|
Thanks for the suggestion @sternenseemann. I didn't see a link to the repo on hackage, and it totally slipped my mind to look for it manually. Issue here: yeyan/xmonad-wallpaper/issues/2. |
Member
|
Cherry-picked as faa7f48140f, should be merged into |
Contributor
Author
|
Thank you! |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
On 2021-06-10, stackage bumped the
randomlibrary from1.1to1.2.0. Unfortunately this breaksxmonad-wallpaper, as that library has a bound limit ofrandom >=1.1 && <1.2.Things done
Fortunately,
xmonad-wallpaperbuilds just fine withrandom-1.2.0. I have tested building the package both by editing the cabal file directly and with my changes here via:nix-build --no-out-link A haskellPackages.xmonad-wallpaper --arg config '{ allowBroken = true; }'I'm currently attempting to rebuild my system with my version of
nixpkgs, but this takes a very long time 😉. Previously my builds failed in under a minute due to the error:Setup: Encountered missing or private dependencies: random ==1.1.*So this looks promising to me.
I contacted
xmonad-wallpaper's maintainer about increasing the bound on hackage, as that's probably the right thing to do and would make this whole exercise unnecessary. Still, I made this PR in case we want to provide a quicker workaround (it would at least be useful for me, as I can't updatenixpkgsuntil this is fixed). But I will, of course, defer to whatever the reviewers think is the best course of action. If this fix is merged, I can make a second PR once the package on hackage is updated.Thanks!
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)