haskellPackages.shellFor: Work around hoogle generation failure#127028
Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom Jun 16, 2021
Merged
haskellPackages.shellFor: Work around hoogle generation failure#127028cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
Workaround for NixOS#82245 Although this doesn't tackle the root cause of a null package sneaking in (via executableHaskellDepends), it does effectively treat the symptom by just ignoring any null packages. Seeing as that issue has been open for more than a year I think this band-aid is necessary.
b8e79a3 to
d8daa7a
Compare
Member
|
LGTM, thanks! I think @expipiplus1 has tested this in NixOS/cabal2nix#505 (comment), so I'll go ahead and merge in. |
Contributor
Author
|
Thanks
…On Wed, 16 Jun 2021, 2:01 pm Dennis Gosnell, ***@***.***> wrote:
Merged #127028 <#127028> into
haskell-updates.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#127028 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGRJXHQE3PRKTYMM2IYBDLTTA44DANCNFSM46YOCWUA>
.
|
Contributor
|
Backport failed for Please cherry-pick the changes locally. git fetch origin release-21.11
git worktree add -d .worktree/backport-127028-to-release-21.11 origin/release-21.11
cd .worktree/backport-127028-to-release-21.11
git checkout -b backport-127028-to-release-21.11
ancref=$(git merge-base 4327400c1b4caa98c6b9fb95d6f82d773885a87e d8daa7af738311a68bacf5af1e4ff9e246a13e47)
git cherry-pick -x $ancref..d8daa7af738311a68bacf5af1e4ff9e246a13e47 |
Contributor
Author
It's good, seems to be there already? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for #82245
Although this doesn't tackle the root cause of a null package sneaking
in (via executableHaskellDepends), it does effectively treat the symptom
by just ignoring any null packages.
Seeing as that issue has been open for more than a year I think this
band-aid is necessary.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)