llvmPackages_7: misc improvements for lldClang#120790
Merged
Ericson2314 merged 4 commits intoNixOS:stagingfrom May 12, 2021
Merged
llvmPackages_7: misc improvements for lldClang#120790Ericson2314 merged 4 commits intoNixOS:stagingfrom
Ericson2314 merged 4 commits intoNixOS:stagingfrom
Conversation
|
Result of 8 packages marked as broken and skipped:
23 packages skipped due to time constraints:
3 packages built successfully:
2 suggestions:
|
10 tasks
sternenseemann
added a commit
to sternenseemann/nixpkgs
that referenced
this pull request
May 10, 2021
Provide a version of nixpkgs which is built using the LLVM toolchain. This is achieved by reusing the useLLVM attribute usable in the cross toolchain bootstrapping which is a) perfectly acceptable and b) the only way to bootstrap a LLVM stdenv across platforms without unreasonable amounts of work. This is mostly working now since we fixed some issues with llvmPackages_7.lldClang in NixOS#119717 and compile glibc with gcc at all times as of NixOS#119786 (since clang can't compile our glibc at the moment). There are seemingly some issues left to be ironed out, for example the C++ library of ncurses fails to build with a linking issue. I have attempted to alleviate that problem with NixOS#120790, but to no avail so far. Nonetheless, having a working pkgsLLVM.hello is a good start. A currently present issue is that there is no way to change the libc since there is some issue with lldClang actually picking up on the set libc. This will need investigation and fixing.
03a5863 to
c188d47
Compare
c188d47 to
8ac82b4
Compare
Ericson2314
approved these changes
May 11, 2021
* Use LLVM_PATH instead of llvm-config * Pass less unnecessary options to cmake
This keeps the "main bootstrap" together.
8ac82b4 to
894f0c6
Compare
10 tasks
Member
|
This was failing eval but I merged as part of #122655 which wasn't. Bisecting |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This stems from my attempts to make
ncurses(more specifically its C++ library) work withuseLLVM == true. While this hasn't worked out yet, the libunwind derivation is at least a bit better now.Curiously, it works with LLVM 8 and I'm not sure what difference between the versions exactly causes that.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)