emacs: Remove clean-env patch and use substituteInPlace#114335
Merged
adisbladis merged 1 commit intoNixOS:masterfrom Feb 25, 2021
Merged
emacs: Remove clean-env patch and use substituteInPlace#114335adisbladis merged 1 commit intoNixOS:masterfrom
adisbladis merged 1 commit intoNixOS:masterfrom
Conversation
835cc1e to
a551249
Compare
This approach applies to _all_ RUN_TEMACS calls and successfully removes -dev paths from the closure and reduces the closure size from ~1.4G to just under ~464M. It's also less brittle than having in-tree patches.
a551249 to
44131d7
Compare
peti
approved these changes
Feb 25, 2021
adisbladis
added a commit
to nix-community/emacs-overlay
that referenced
this pull request
Feb 25, 2021
This is now fixed upstream in nixpkgs using substituteInPlace which means we don't have to carry patches. See NixOS/nixpkgs#114335
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This approach applies to all
RUN_TEMACScalls and successfully removes -dev paths from the closure and reduces the closure size from ~1.4G to just under ~464M.It's also less brittle than having in-tree patches.
Closes #98755
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cc @edolstra