Skip to content

microdnf: init at 3.6.0, libdnf: init at 0.55.2#107348

Merged
jtojnar merged 2 commits intoNixOS:masterfrom
rb2k:microdnf
Dec 23, 2020
Merged

microdnf: init at 3.6.0, libdnf: init at 0.55.2#107348
jtojnar merged 2 commits intoNixOS:masterfrom
rb2k:microdnf

Conversation

@rb2k
Copy link
Copy Markdown
Contributor

@rb2k rb2k commented Dec 21, 2020

This PR adds derivations for microdnf and libdnf. Both support darwin and linux.
I split this in two commits. libdnf first, microdnf after.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabianhjr fabianhjr mentioned this pull request Dec 21, 2020
Merged
@rb2k rb2k force-pushed the microdnf branch 2 times, most recently from 45659a2 to a4379d7 Compare December 21, 2020 22:01
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 21, 2020
@ofborg ofborg bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Dec 21, 2020
@rb2k rb2k marked this pull request as draft December 21, 2020 22:57
@rb2k rb2k force-pushed the microdnf branch 3 times, most recently from 9f43c75 to 05ea738 Compare December 21, 2020 23:11
@rb2k rb2k marked this pull request as ready for review December 21, 2020 23:12
@rb2k
Copy link
Copy Markdown
Contributor Author

rb2k commented Dec 21, 2020

Result of nixpkgs-review pr 107348 run on x86_64-linux 1

2 packages built:
  • libdnf
  • microdnf

@rb2k
Copy link
Copy Markdown
Contributor Author

rb2k commented Dec 21, 2020

Result of nixpkgs-review pr 107348 run on x86_64-darwin 1

2 packages built:
  • libdnf
  • microdnf

@rb2k rb2k mentioned this pull request Dec 22, 2020
Merged
10 tasks
SuperSandro2000
SuperSandro2000 requested changes Dec 22, 2020
View reviewed changes
jtojnar
jtojnar reviewed Dec 22, 2020
View reviewed changes
@rb2k rb2k force-pushed the microdnf branch 2 times, most recently from de66c2a to f898d03 Compare December 22, 2020 21:50
@ofborg ofborg bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 22, 2020
@rb2k rb2k force-pushed the microdnf branch 2 times, most recently from e9ae0d2 to f4f1bca Compare December 22, 2020 22:03
@rb2k rb2k force-pushed the microdnf branch 2 times, most recently from fb4f263 to 6678b31 Compare December 22, 2020 22:21
@ofborg ofborg bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 22, 2020
@rb2k rb2k force-pushed the microdnf branch 2 times, most recently from d527f1a to 2bf1eac Compare December 22, 2020 22:36
@ofborg ofborg bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 22, 2020
jtojnar
jtojnar reviewed Dec 22, 2020
View reviewed changes
@rb2k rb2k mentioned this pull request Dec 22, 2020
Closed
@rb2k rb2k force-pushed the microdnf branch 2 times, most recently from 4b1a0b0 to 6f9436f Compare December 22, 2020 23:31
jtojnar
jtojnar reviewed Dec 22, 2020
View reviewed changes
@rb2k rb2k force-pushed the microdnf branch 4 times, most recently from 9c7cef5 to fb8a57a Compare December 22, 2020 23:43
jtojnar
jtojnar reviewed Dec 22, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM apart from a minor nit on attribute ordering (patches should be just below src`) https://github.com/jtojnar/nixpkgs-hammering/blob/9965b8d88f2112097d1bbd84070b51634dfb3af7/explanations/attribute-ordering.md#examples

@rb2k
Copy link
Copy Markdown
Contributor Author

rb2k commented Dec 22, 2020

Result of nixpkgs-review pr 107348 run on x86_64-darwin 1

2 packages built:
  • libdnf
  • microdnf

@rb2k
Copy link
Copy Markdown
Contributor Author

rb2k commented Dec 22, 2020

Result of nixpkgs-review pr 107348 run on x86_64-linux 1

2 packages built:
  • libdnf
  • microdnf

@jtojnar jtojnar merged commit 00f6d35 into NixOS:master Dec 23, 2020
rb2k
rb2k commented Dec 23, 2020
View reviewed changes
pkgs/tools/package-management/libdnf/default.nix
"-DWITH_GTKDOC=OFF"
"-DWITH_HTML=OFF"
"-DWITH_BINDINGS=OFF"
"-DWITH_ZCHUNK=OFF"
Copy link
Copy Markdown
Contributor Author

@rb2k rb2k Dec 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nima2007 Once you took a stab at zchunk, we might want to enable support in here :)

@rb2k rb2k deleted the microdnf branch December 23, 2020 00:30
@rb2k
Copy link
Copy Markdown
Contributor Author

rb2k commented Mar 24, 2021

As promised, here is the attempt at upstreaming the patch rpm-software-management/libdnf#1178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar jtojnar approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rb2k @jtojnar @SuperSandro2000