Add darwin compatibility fixes.#1178
Merged
Conan-Kudo merged 1 commit intorpm-software-management:dnf-4-masterfrom Mar 26, 2021
Merged
Add darwin compatibility fixes.#1178Conan-Kudo merged 1 commit intorpm-software-management:dnf-4-masterfrom
Conan-Kudo merged 1 commit intorpm-software-management:dnf-4-masterfrom
Conversation
10 tasks
Conan-Kudo
approved these changes
Mar 26, 2021
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These patches are the ones we use over in nix to get this to compile on darwin: https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/package-management/libdnf/darwin.patch
I am not the most prolific C developer, so any comments about how to improve this would be welcome.
At this point, it's compiles fine on darwin and is functional. It allows us to use microdnf on macOS.