-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
Automatic finalAttrs pattern migration #293452
Copy link
Copy link
Open
Labels
1.severity: significantNovel ideas, large API changes, notable refactorings, issues with RFC potential, etc.Novel ideas, large API changes, notable refactorings, issues with RFC potential, etc.6.topic: architectureRelating to code and API architecture of NixpkgsRelating to code and API architecture of Nixpkgs
Metadata
Metadata
Assignees
Labels
1.severity: significantNovel ideas, large API changes, notable refactorings, issues with RFC potential, etc.Novel ideas, large API changes, notable refactorings, issues with RFC potential, etc.6.topic: architectureRelating to code and API architecture of NixpkgsRelating to code and API architecture of Nixpkgs
Fields
Give feedbackNo fields configured for issues without a type.
I recently wrote a tool that automatically performs a migration to the
finalAttrspattern (#119942), and I believe it is now robust enough to be let loose on nixpkgs.However this is the first large treewide change I'm performing, so I'm not 100% sure how to proceed. Some questions:
cc @drupol who was interested in this
Example run of the tool on pkgs/applications and pkgs/by-name: https://github.com/fgaz/nixpkgs/commits/finalattrs-test-8/