Skip to content

Port nix.sh to the fish shell#626

Closed
tchajed wants to merge 1 commit intoNixOS:masterfrom
tchajed:fish-profile
Closed

Port nix.sh to the fish shell#626
tchajed wants to merge 1 commit intoNixOS:masterfrom
tchajed:fish-profile

Conversation

@tchajed
Copy link
Copy Markdown

@tchajed tchajed commented Aug 28, 2015

Sourcing nix.sh won't work on fish shell since it doesn't use the same syntax. This patch adds a new nix.fish that can be sourced from fish.

@domenkozar
Copy link
Copy Markdown
Member

I've seen requests for this, it's going to be pain to maintain (we'd need a test).

@Ericson2314
Copy link
Copy Markdown
Member

@domenkozar Hmm? I think it would be pretty popular and thus less likely to rot. But what tests were you thinking of?

@domenkozar
Copy link
Copy Markdown
Member

domenkozar commented Jun 3, 2016

@tchajed could you rebase and sync with recent changes? I don't see why we shouldn't support this as long as it's maintained.

@yacinehmito
Copy link
Copy Markdown

@tchajed What is the status on this please ? I would be happy to help.

@tchajed
Copy link
Copy Markdown
Author

tchajed commented Sep 25, 2016

It looks like the sh profile has become more complicated. While I fixed merge conflicts, the new profile needs to be translated to fish again. I'm not able to get nix to compile, and since I don't actually use it I'd rather pass this on to someone who will maintain it.

@gpyh: feel free to use this as a starting point and create your own pull request! I'd rather not submit code I haven't tested.

@nhooyr
Copy link
Copy Markdown

nhooyr commented Oct 12, 2016

I'm gonna try and work on this in a new PR.

@pickfire
Copy link
Copy Markdown

Any news on this?

@tchajed
Copy link
Copy Markdown
Author

tchajed commented May 11, 2020

I'm closing in favor of the latest attempt by @asymmetric in #1090, which hopefully gets resolved and merged.

@tchajed tchajed closed this May 11, 2020
@pickfire
Copy link
Copy Markdown

@tchajed @asymmetric issue was closed.

Ma27 added a commit to Ma27/nix that referenced this pull request Mar 8, 2026
…quisites

Closes NixOS#334
Closes NixOS#626

This is loosely based on upstream PR#10877[1], but heavily changed to
use the graph logic from `nix why-depends`.

`precise` is `false` here since the out-path of the drv being built
isn't registered yet, so the path accessor cannot scan through files
yet.

Example output (from an openssh build with `pcsclite.lib` & `glibc` in
`disallowedRequisites`):

    error: output '/nix/store/hr8lmmjmd1jk6s3p5ymggyk4am7n2lmb-openssh-10.0p2' is not allowed to refer to the following paths:
           /nix/store/p6r5awz3ywrz66symnrn0xb85xzmcysf-pcsclite-2.3.0-lib
           /nix/store/q4wq65gl3r8fy746v9bbwgx4gzn0r2kl-glibc-2.40-66
           Shown below are chains that lead to the forbidden path(s).
           /nix/store/hr8lmmjmd1jk6s3p5ymggyk4am7n2lmb-openssh-10.0p2
           └───/nix/store/ys91ywnwikm14xznwk3cdbprapv2m37z-libfido2-1.16.0
               └───/nix/store/p6r5awz3ywrz66symnrn0xb85xzmcysf-pcsclite-2.3.0-lib
           /nix/store/hr8lmmjmd1jk6s3p5ymggyk4am7n2lmb-openssh-10.0p2
           ├───/nix/store/q4wq65gl3r8fy746v9bbwgx4gzn0r2kl-glibc-2.40-66
           ├───/nix/store/6r4zqb04fq5l5l4zghq76wvcpz7dwd35-linux-pam-1.6.1
           │   ├───/nix/store/q4wq65gl3r8fy746v9bbwgx4gzn0r2kl-glibc-2.40-66
           [...]

[1] NixOS#10877

Co-authored-by: Robert Hensing <robert@roberthensing.nl>
Change-Id: Ib30024c0d9e45c1160bf0134f7d3ba17dbdeff47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants