Make more URLs parsed, most notably FileTransferRequest::url#13803
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Aug 23, 2025
Merged
Make more URLs parsed, most notably FileTransferRequest::url#13803Ericson2314 merged 1 commit intoNixOS:masterfrom
FileTransferRequest::url#13803Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
18735fc to
f7ec640
Compare
xokdvium
reviewed
Aug 21, 2025
xokdvium
reviewed
Aug 21, 2025
Trying to gradually replace the use of strings with better types in ways that makes sense.
f7ec640 to
3e86d75
Compare
xokdvium
approved these changes
Aug 23, 2025
Contributor
xokdvium
left a comment
There was a problem hiding this comment.
Looks good. Should help with the s3 store curl transition, though this is a good cleanup all on its own.
|
🎉 All dependencies have been resolved ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Trying to gradually replace the use of strings with better types in ways that makes sense.
Context
Depends on #13812
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.