Limit to lenient parsing of non-standard URLs only where needed #13812
Merged
Ericson2314 merged 2 commits intoNixOS:masterfrom Aug 23, 2025
Merged
Limit to lenient parsing of non-standard URLs only where needed #13812Ericson2314 merged 2 commits intoNixOS:masterfrom
Ericson2314 merged 2 commits intoNixOS:masterfrom
Conversation
917f578 to
7cb8c55
Compare
This allows us to put `parseURL` in more spots without furthering technical debt.
7cb8c55 to
72a548e
Compare
xokdvium
approved these changes
Aug 23, 2025
| if (element.source) { | ||
| result = getNameFromURL(parseURL(element.source->to_string())); | ||
| // Seems to be for Flake URLs | ||
| result = getNameFromURL(parseURL(element.source->to_string(), /*lenient=*/true)); |
Contributor
There was a problem hiding this comment.
Yeah, nix profile does some weird stuff with URLs which I don't quite understand. getNameFromURL is particularly bad.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This allows us to put
parseURLin more spots without furthering technical debt.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.