Skip to content

lockFlake(): Allow registry lookups for overridden inputs#13284

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
getchoo-contrib:getchoo/override-input-local-registry
Jun 6, 2025
Merged

lockFlake(): Allow registry lookups for overridden inputs#13284
Mic92 merged 1 commit intoNixOS:masterfrom
getchoo-contrib:getchoo/override-input-local-registry

Conversation

@getchoo
Copy link
Copy Markdown
Member

@getchoo getchoo commented May 28, 2025

Motivation

Similar to installables and --override-flake, it makes sense to allow local registry lookups for inputs passed by --override-input

Context

Fixes #13144

This should be backported to 2.28, as it currently affects all users by default on NixOS 25.05


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@getchoo getchoo requested a review from edolstra as a code owner May 28, 2025 02:24
@getchoo getchoo force-pushed the getchoo/override-input-local-registry branch from 2465419 to d0a2323 Compare May 28, 2025 04:25
Copy link
Copy Markdown
Member

@Mic92 Mic92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this makes sense.

@bryango
Copy link
Copy Markdown
Member

bryango commented Jun 5, 2025

I have tested this PR on top of 2.28.3 (pkgs.nixVersions.stable) and it works great (the backported patch is here). Please consider fast tracking it as the regression has been a pain point for many many users 🥺 (as is evident from the issue tracker).

@Mic92 Mic92 merged commit 37b4407 into NixOS:master Jun 6, 2025
12 checks passed
@Mic92 Mic92 added backport 2.28-maintenance Automatically creates a PR against the branch backport 2.29-maintenance Automatically creates a PR against the branch labels Jun 6, 2025
mergify bot added a commit that referenced this pull request Jun 6, 2025
…3284

lockFlake(): Allow registry lookups for overridden inputs (backport #13284)
@getchoo getchoo deleted the getchoo/override-input-local-registry branch June 6, 2025 18:07
Mic92 added a commit that referenced this pull request Jun 11, 2025
…3284

lockFlake(): Allow registry lookups for overridden inputs (backport #13284)
@nixos-discourse
Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-use-local-nixpkgs-from-registry-when-evaluating-a-flake/65598/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.28-maintenance Automatically creates a PR against the branch backport 2.29-maintenance Automatically creates a PR against the branch backports created Does not require attention and can be filtered away

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--override-input now ignores user and system registries

5 participants