Emit warnings for IFDs with new trace-import-from-derivation option#13279
Merged
Mic92 merged 2 commits intoNixOS:masterfrom May 27, 2025
Merged
Conversation
Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
roberth
reviewed
Jul 30, 2025
| }; | ||
|
|
||
| Setting<bool> traceImportFromDerivation{ | ||
| this, false, "trace-import-from-derivation", |
Member
There was a problem hiding this comment.
This should probably be warn-import-from-derivation to conform with the other warning options.
lf-
pushed a commit
to lix-project/lix
that referenced
this pull request
Mar 5, 2026
This is intended to be a softer version of `allow-import-from-derivation`, allowing for users to only flag when IFD is encountered rather than error out Based-on: NixOS/nix#13279 Co-authored-by: gustavderdrache <alex.ford@determinate.systems> Co-authored-by: Eelco Dolstra <edolstra@gmail.com> Change-Id: I879a444e3a24b4e82a8cea3a5a94834c78c3924a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While we have the
allow-import-from-derivationoption to deny IFDs, sometimes users would like to observe IFDs during CI processes to gradually phase the idiom out. This PR adds atrace-import-from-derivationoption that, when set, logs a simple warning to the console.Since this is intended for consumption by both humans and CI systems that can read logs, a test is included to ensure the warning message does not change accidentally.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.