nix-profile.fish: Do not check $USER#13041
Merged
Mic92 merged 1 commit intoNixOS:masterfrom Apr 17, 2025
Merged
Conversation
While it seems unlikely that `$USER` will be unset while `$HOME` is set, as `$USER` is not used in the script and as `nix-profile-daemon.fish` is not checking `$USER`, it seems better to remove this check. `nix-profile.fish` and `nix-profile-daemon.fish` now become identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While it seems unlikely that
$USERwill be unset while$HOMEis set, as$USERis not used in the script and asnix-profile-daemon.fishis not checking$USER, it seems better to remove this check.Context
If both #12423 and #13040 are merged in addition to this change,
nix-profile.fishandnix-profile-daemon.fishbecome identical.The original list of changes between these files is tracked here.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.