Skip to content

nix-profile.fish: Add local state bin to $PATH#12423

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
illia-bobyr:fish-profile-local-state-bin-in-PATH
Apr 18, 2025
Merged

nix-profile.fish: Add local state bin to $PATH#12423
Mic92 merged 1 commit intoNixOS:masterfrom
illia-bobyr:fish-profile-local-state-bin-in-PATH

Conversation

@illia-bobyr
Copy link
Copy Markdown
Contributor

Motivation

It seems reasonable to add both $HOME/.profile/bin and @localstatedir@/nix/profiles/default/bin to $PATH for both user local and daemon based nix execution.
Nix daemon execution mode does not affect these paths.

Context

Further reduce differences between nix-profile.fish and nix-profile-daemon.fish.
A higher level list of all the differences is here.


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@illia-bobyr illia-bobyr requested a review from edolstra as a code owner February 5, 2025 00:13
@illia-bobyr illia-bobyr force-pushed the fish-profile-local-state-bin-in-PATH branch from 35b80d5 to c09b6da Compare February 5, 2025 09:45
It seems reasonable to add both `$HOME/.profile/bin` and
`@localstatedir@/nix/profiles/default/bin` to `$PATH` for both user
local and daemon based nix execution.  Nix daemon execution mode does
not affect these path.
@illia-bobyr illia-bobyr force-pushed the fish-profile-local-state-bin-in-PATH branch from c09b6da to fc8c11b Compare April 17, 2025 00:13
@illia-bobyr
Copy link
Copy Markdown
Contributor Author

A reminder that this PR is still relevant.

@illia-bobyr
Copy link
Copy Markdown
Contributor Author

@Mic92 As you have looked at #13040, #13041, maybe you could consider reviewing this change as well?

Merging this change in will make nix-profile.fish and nix-profile-daemon.fish identical.
As they probably should be, based on the functionality they currently contain.

@Mic92 Mic92 merged commit f683a55 into NixOS:master Apr 18, 2025
12 checks passed
@illia-bobyr illia-bobyr deleted the fish-profile-local-state-bin-in-PATH branch April 18, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants