Skip to content

Test derivation options with content-addressing too (backport #13022)#13028

Merged
Ericson2314 merged 2 commits into2.28-maintenancefrom
mergify/bp/2.28-maintenance/pr-13022
Apr 15, 2025
Merged

Test derivation options with content-addressing too (backport #13022)#13028
Ericson2314 merged 2 commits into2.28-maintenancefrom
mergify/bp/2.28-maintenance/pr-13022

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Apr 15, 2025

Motivation

Now, both the unit and functional tests relating to derivation options
are tested both ways -- with input addressing and content-addressing
derivations.

Context

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

This is an automatic backport of pull request #13022 done by [Mergify](https://mergify.com).

@mergify mergify bot requested review from Ericson2314 and edolstra as code owners April 15, 2025 11:28
@mergify mergify bot added automatic backport This PR is a backport produced by automation (does not trigger backporting) merge-queue labels Apr 15, 2025
@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Apr 15, 2025
@Ericson2314
Use the same variable for content addressing in functional tests
37bcd29 
`CONTENT_ADDRESSED` -> `NIX_TESTS_CA_BY_DEFAULT`

(cherry picked from commit 7acc229)
@Ericson2314
Test derivation options with content-addressing too
f191841 
Now, both the unit and functional tests relating to derivation options
are tested both ways -- with input addressing and content-addressing
derivations.

(cherry picked from commit 307dbe9)
@Ericson2314 Ericson2314 force-pushed the mergify/bp/2.28-maintenance/pr-13022 branch from 3774162 to f191841 Compare April 15, 2025 15:25
@Ericson2314
Copy link
Copy Markdown
Member

Ericson2314 commented Apr 15, 2025

@mergify queue

@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Apr 15, 2025 •
edited
Loading

queue

🛑 The pull request could not be merged

Details

This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 2 of 4 required status checks are in progress.)

@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Apr 15, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #13028 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 2 of 4 required status checks are in progress.).

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@Ericson2314 Ericson2314 merged commit 5f0ddd7 into 2.28-maintenance Apr 15, 2025
25 of 27 checks passed
@Ericson2314 Ericson2314 deleted the mergify/bp/2.28-maintenance/pr-13022 branch April 15, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@edolstra edolstra Awaiting requested review from edolstra edolstra is a code owner

Assignees

No one assigned

Labels

automatic backport This PR is a backport produced by automation (does not trigger backporting) merge-queue with-tests Issues related to testing. PRs with tests have some priority

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Ericson2314