Skip to content

Unexpose config headers (low hanging fruit only) (backport #12773)#12822

Merged
mergify[bot] merged 1 commit into2.28-maintenancefrom
mergify/bp/2.28-maintenance/pr-12773
Mar 31, 2025
Merged

Unexpose config headers (low hanging fruit only) (backport #12773)#12822
mergify[bot] merged 1 commit into2.28-maintenancefrom
mergify/bp/2.28-maintenance/pr-12773

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Mar 31, 2025

  • Some headers were completely redundant and have been removed.
  • Other headers have been turned private.
  • Unnecessary meson.build code has been removed.
  • libutil-tests now has a private config header, where previously it had none. This removes the need to expose a package version macro publicly.

I've left a few comments about usage as a public header. It doesn't seem like all that many places.

Motivation

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.


This is an automatic backport of pull request #12773 done by [Mergify](https://mergify.com).

- Some headers were completely redundant and have been removed.
- Other headers have been turned private.
- Unnecessary meson.build code has been removed.
- libutil-tests now has a private config header, where previously
  it had none. This removes the need to expose a package version
  macro publicly.

(cherry picked from commit b86a760)
@mergify mergify bot added the automatic backport This PR is a backport produced by automation (does not trigger backporting) label Mar 31, 2025
@mergify mergify bot requested a review from Ericson2314 as a code owner March 31, 2025 18:18
@mergify mergify bot added the merge-queue label Mar 31, 2025
@mergify mergify bot requested a review from edolstra as a code owner March 31, 2025 18:18
@github-actions github-actions bot added new-cli Relating to the "nix" command with-tests Issues related to testing. PRs with tests have some priority c api Nix as a C library with a stable interface labels Mar 31, 2025
@Ericson2314
Copy link
Copy Markdown
Member

@mergify queue

@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Mar 31, 2025

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 5241068

mergify bot added a commit that referenced this pull request Mar 31, 2025
@mergify mergify bot merged commit 5241068 into 2.28-maintenance Mar 31, 2025
27 checks passed
@mergify mergify bot deleted the mergify/bp/2.28-maintenance/pr-12773 branch March 31, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automatic backport This PR is a backport produced by automation (does not trigger backporting) c api Nix as a C library with a stable interface merge-queue new-cli Relating to the "nix" command with-tests Issues related to testing. PRs with tests have some priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants