Move RestrictedStore into its own file+header#12658
Merged
mergify[bot] merged 2 commits intoNixOS:masterfrom Mar 19, 2025
Merged
Move RestrictedStore into its own file+header#12658mergify[bot] merged 2 commits intoNixOS:masterfrom
RestrictedStore into its own file+header#12658mergify[bot] merged 2 commits intoNixOS:masterfrom
Conversation
Member
|
First commit: trivial move to superclass with rationale ✔️ |
Member
|
I like the second commit a lot. We should definitely have much much less stuff in header files, especially where we’re using abstract classes anyway. LGTM. |
RestrictedStore into its own file+header
Member
Author
|
This is now just the last commit, since @roberth approved the previous 2. |
f4c0d42 to
34b7751
Compare
edolstra
reviewed
Mar 17, 2025
Perhaps more significantly, it no longer knows about
`LocalDerivationGoal`, and without any effort it also compiles on
Windows just fine. (`local-derivation-goal.{cc,hh}` is currently skipped
on Windows.)
Even when the type is not currently declared in a header, I still consider this a more future-proof style.
34b7751 to
5283589
Compare
Member
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at d10f948 |
37 tasks
37 tasks
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Split off the
RestrictedStore, as it is quite separate from building (it could be used for other purposes).I have more things queued up for #12628 but where the approach is a bit more uncertain and up for debate. These commit and the two that I moved to #12662, in contrast, I think are exceptionally "unopinionated" changes that are good no matter what approach we take.
Context
Progress on #12628
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.