Realisations use regular drv paths again#12464
Merged
Mic92 merged 1 commit intoNixOS:masterfrom Feb 18, 2026
Merged
Conversation
6f610de to
be5cfe4
Compare
be5cfe4 to
7b01c8b
Compare
7b01c8b to
546d826
Compare
a031df7 to
4f9435b
Compare
4f9435b to
46fde9b
Compare
46fde9b to
d150215
Compare
9f3fdcf to
c9ac039
Compare
e0eb7f7 to
aa43f8d
Compare
aa43f8d to
043eed8
Compare
Member
|
I applied an earlier version of this PR https://github.com/Mic92/nix-1/tree/broken-main |
Member
|
when I applied this pr, After dropping the patches from my fork, it does again. This happened with all nix versions I tested btw, while the faulty version was running as the nix-daemon. |
Open
4cf2e4f to
d9e2cd8
Compare
ebc5b58 to
211dc75
Compare
Ericson2314
commented
Feb 9, 2026
src/libstore-tests/realisation.cc
Outdated
Comment on lines
+48
to
+56
| Realisation simple{ | ||
| { | ||
| .outPath = StorePath{"g1w7hy3qg1w7hy3qg1w7hy3qg1w7hy3q-foo"}, | ||
| }, | ||
| { | ||
| .drvPath = StorePath{"g1w7hy3qg1w7hy3qg1w7hy3qg1w7hy3q-bar.drv"}, | ||
| .outputName = "foo", | ||
| }, | ||
| }; |
Member
Author
There was a problem hiding this comment.
Can move this back outside, like it was before this commit.
d21cbe2 to
770a5f5
Compare
Fix NixOS#11897 As described in the issue, this makes for a simpler and much more intuitive notion of a realisation key. This is better for pedagogy, and interoperability between more tools. The way the issue was written was that we would switch to only having shallow realisations first, and then do this. But going to only shallow realisations is more complex change, and it turns out we weren't even testing for the benefits that derivation hashes (modulo FODs) provided in the deep realisation case, so I now just want to do this first. Doing this gets the binary cache data structures in order, which will unblock the Hydra fixed-output-derivation tracking work. I don't want to delay that work while I figure out the changes needed for shallow-realisations only. This reverts commit bab1cda. Co-authored-by: Amaan Qureshi <git@amaanq.com>
770a5f5 to
4f91e95
Compare
Mic92
approved these changes
Feb 18, 2026
Member
Actually, I thought, I was no longer able to reproduce the bug, but I just now still able to reproduce this. But only with older nix versions, not with the current nix version. |
Member
|
Ah. Actually even with the same nix version... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #11897
As described in the issue, this makes for a simpler and much more intuitive notion of a realisation key. This is better for pedagogy, and interoperability between more tools.
Context
The way the issue was written was that we would switch to only having shallow realisations first, and then do this. But going to only shallow realisations is more complex change, and it turns out we weren't even testing for the benefits that derivation hashes (modulo FODs) provided in the deep realisation case, so I now just want to do this first.
Doing this gets the binary cache data structures in order, which will unblock the Hydra fixed-output-derivation tracking work. I don't want to delay that work while I figure out the changes needed for shallow-realisations only.
Revert "Use the hash modulo in the derivation outputs"
This reverts commit bab1cda.
Depends on #14247
Depends on #14257
Depends on #14648
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.