Cleanup misc builder tech debt#14257
Merged
Ericson2314 merged 3 commits intoNixOS:masterfrom Oct 15, 2025
Merged
Conversation
edolstra
approved these changes
Oct 15, 2025
edolstra
reviewed
Oct 15, 2025
| std::shared_ptr<PathSubstitutionGoal> makePathSubstitutionGoal( | ||
| const StorePath & storePath, RepairFlag repair = NoRepair, std::optional<ContentAddress> ca = std::nullopt); | ||
| std::shared_ptr<DrvOutputSubstitutionGoal> makeDrvOutputSubstitutionGoal( | ||
| const DrvOutput & id, RepairFlag repair = NoRepair, std::optional<ContentAddress> ca = std::nullopt); |
Member
There was a problem hiding this comment.
Didn't we use to have the ability to repair store paths via substitution? Did that go away?
Member
Author
There was a problem hiding this comment.
@edolstra that never got plumbed through for this (which is just for CA derivations).
Eventually I will move the actual fetching of the outputs out of this (make this just about the realisations), and then it will be easier to plumb that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
See each commit for details
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.