installer: make sure we can always test the installer in ci and locally#12059
Merged
roberth merged 2 commits intoNixOS:masterfrom Dec 16, 2024
Merged
installer: make sure we can always test the installer in ci and locally#12059roberth merged 2 commits intoNixOS:masterfrom
roberth merged 2 commits intoNixOS:masterfrom
Conversation
346a437 to
6d5cf02
Compare
Just now there is a dependency on cachix, which means we cannot test the installer in CI if forks do not have the necessary secrets set up. We replace this with a simple http server that serves the installer and can be both used in CI and locally.
6d5cf02 to
6162e12
Compare
Member
Author
|
When merging this test, please also update "Required checks" in the github settings, as the installer test is now a build matrix. |
roberth
approved these changes
Dec 16, 2024
| pid=$! | ||
|
|
||
| while ! curl -s "http://localhost:$PORT"; do | ||
| sleep 1 |
Member
There was a problem hiding this comment.
Suggested change
| sleep 1 | |
| sleep 0.1 |
Member
|
Related |
This was referenced Dec 16, 2024
Merged
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-12-16-nix-team-meeting-minutes-203/57483/1 |
Mic92
added a commit
that referenced
this pull request
Jan 6, 2025
…2059 installer: make sure we can always test the installer in ci and locally (backport #12059)
Mic92
added a commit
that referenced
this pull request
Jan 6, 2025
…2059 installer: make sure we can always test the installer in ci and locally (backport #12059)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just now there is a dependency on cachix, which means we cannot test the installer in CI if forks do not have the necessary secrets set up. We replace this with a simple http server that serves the installer and can be both used in CI and locally.
Another nice side effect is that now every pull request has a downloadable installer: https://github.com/NixOS/nix/actions/runs/12340760590
Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.