hackage2nix: Remove obsolete maintenance scripts and update README.md#519
Merged
maralorn merged 1 commit intoNixOS:masterfrom Sep 23, 2021
Merged
hackage2nix: Remove obsolete maintenance scripts and update README.md#519maralorn merged 1 commit intoNixOS:masterfrom
maralorn merged 1 commit intoNixOS:masterfrom
Conversation
Member
sternenseemann
left a comment
There was a problem hiding this comment.
Thank you! I've thought to do this many times, but always ended up putting it off…
hackage2nix/README.md
Outdated
|
|
||
| _Replace `git@github.com:NixOS/nixpkgs.git` with a fork you have push access | ||
| to._ | ||
| During development you can just run `cabal build`. To get a nix-shell for development run: |
Member
There was a problem hiding this comment.
I'd just recommend the dev setup we have in ../README.md?
hackage2nix/README.md
Outdated
| There is a [video on YouTube](https://www.youtube.com/watch?v=qX0mgtSm360) | ||
| that gives a thorough walk-through of these steps. | ||
| It gets used by the | ||
| `maintainers/scripts/haskell/regenerate-hackage-packages.sh` in nixpkgs. There |
Member
There was a problem hiding this comment.
Suggested change
| `maintainers/scripts/haskell/regenerate-hackage-packages.sh` in nixpkgs. There | |
| [`maintainers/scripts/haskell/regenerate-hackage-packages.sh`](https://github.com/NixOS/nixpkgs/blob/haskell-updates/maintainers/scripts/haskell/regenerate-hackage-packages.sh) script in nixpkgs. There |
cdepillabout
approved these changes
Sep 23, 2021
6eb867a to
534546c
Compare
sternenseemann
added a commit
that referenced
this pull request
Jul 27, 2022
* Many Haskell-related files are no longer rooted to the repository root * hackage2nix ignores are no longer relevant after #519.
sternenseemann
added a commit
that referenced
this pull request
Oct 9, 2022
* Many Haskell-related files are no longer rooted to the repository root * hackage2nix ignores are no longer relevant after #519.
sternenseemann
added a commit
that referenced
this pull request
Oct 9, 2022
* Many Haskell-related files are no longer rooted to the repository root * hackage2nix ignores are no longer relevant after #519.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All those scripts (or rather further developed versions of them) now live under
maintainers/scripts/haskellin nixpkgs.