Skip to content

Adding dependencies E2E test#18493

Merged
insomnious merged 11 commits intomasterfrom
18297-full-dependency-test
Oct 13, 2025
Merged

Adding dependencies E2E test#18493
insomnious merged 11 commits intomasterfrom
18297-full-dependency-test

Conversation

@IDCs
Copy link
Contributor

@IDCs IDCs commented Oct 6, 2025

  • fully downloads and installs collections
  • added proper vortex-api mock
  • fixed a couple of small bugs

closes #18297

- fully downloads and installs collections
- added proper vortex-api mock
- fixed a couple of small bugs
@IDCs IDCs requested a review from insomnious October 6, 2025 13:29
Copy link
Contributor

@insomnious insomnious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting a couple of errors...

  console.error
    Error: Uncaught [TypeError: speedCB is not a function]
        at reportException (C:\work\Vortex\node_modules\jsdom\lib\jsdom\living\helpers\runtime-script-errors.js:66:24)
        at Timeout.task [as _onTimeout] (C:\work\Vortex\node_modules\jsdom\lib\jsdom\browser\Window.js:525:9)
        at listOnTimeout (node:internal/timers:588:17)
        at processTimers (node:internal/timers:523:7) {
      detail: TypeError: speedCB is not a function
          at speedCalcCB (C:\work\Vortex\src\extensions\download_management\DownloadManager.ts:918:7)
          at C:\work\Vortex\src\extensions\download_management\SpeedCalculator.ts:28:7
          at Timeout.task [as _onTimeout] (C:\work\Vortex\node_modules\jsdom\lib\jsdom\browser\Window.js:520:19)
          at listOnTimeout (node:internal/timers:588:17)
          at processTimers (node:internal/timers:523:7),
      type: 'unhandled exception'
    }

and also (I've checked that the API key does exist)

info: queueing download mock-short-id-h7sobwvv3
warn: chunk error id=0, err=No valid URL for this download, errorCode=undefined, ended=false, , networkRetries=0, dataReceived=false
info: download failed downloadId=mock-short-id-f0ccq8epo, message=No valid URL for this download

Error: No valid URL for this download
    at DownloadWorker.startDownload (C:\work\Vortex\src\extensions\download_management\DownloadManager.ts:317:24)
    at DownloadWorker.assignJob (C:\work\Vortex\src\extensions\download_management\DownloadManager.ts:235:12)
    at C:\work\Vortex\src\extensions\download_management\DownloadManager.ts:194:16
    at tryCatcher (C:\work\Vortex\node_modules\bluebird\js\release\util.js:16:23)
    at Promise._settlePromiseFromHandler (C:\work\Vortex\node_modules\bluebird\js\release\promise.js:547:31)
    at Promise._settlePromise (C:\work\Vortex\node_modules\bluebird\js\release\promise.js:604:18)

@insomnious insomnious merged commit 5df8052 into master Oct 13, 2025
1 check passed
@insomnious insomnious deleted the 18297-full-dependency-test branch October 13, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add jest tests for the 1.16 refactor work where possible

2 participants