Hide Instant Camera Cell #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideIntroduces a new "Hide Instant Camera" toggle and integrates it into the attachment gallery to suppress the instant camera cell and preview when enabled. Entity relationship diagram for new HideInstantCamera config itemerDiagram
NekoConfig ||--o| ConfigItem : has
ConfigItem {
string key
string type
bool defaultValue
}
NekoConfig {
ConfigItem hideInstantCamera
}
Class diagram for updated NekoConfig and settings integrationclassDiagram
class NekoConfig {
+ConfigItem useCustomEmoji
+ConfigItem repeatConfirm
+ConfigItem disableInstantCamera
+ConfigItem hideInstantCamera
+ConfigItem showSeconds
+ConfigItem enablePublicProxy
}
class NekoChatSettingsActivity {
-AbstractConfigCell hideKeyboardOnChatScrollRow
-AbstractConfigCell rearVideoMessagesRow
-AbstractConfigCell disableInstantCameraRow
-AbstractConfigCell hideInstantCameraRow
-AbstractConfigCell disableVibrationRow
-AbstractConfigCell disableProximityEventsRow
-AbstractConfigCell disableTrendingRow
}
NekoChatSettingsActivity --> NekoConfig: uses
NekoConfig <|-- ConfigItem
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `TMessagesProj/src/main/java/org/telegram/ui/Components/ChatAttachAlertPhotoLayout.java:2391` </location>
<code_context>
adapter.notifyDataSetChanged();
}
- if (!parentAlert.destroyed && parentAlert.isShowing() && deviceHasGoodCamera && parentAlert.getBackDrawable().getAlpha() != 0 && !cameraOpened && !NekoConfig.disableInstantCamera.Bool()) {
+ if (!parentAlert.destroyed && parentAlert.isShowing() && deviceHasGoodCamera && parentAlert.getBackDrawable().getAlpha() != 0 && !cameraOpened && !NekoConfig.disableInstantCamera.Bool() && !NekoConfig.hideInstantCamera.Bool()) {
showCamera();
}
</code_context>
<issue_to_address>
**question:** Potential for conflicting config flags: disable vs hide instant camera.
Please clarify or document the expected behavior when both flags are set, or enforce mutual exclusivity if that matches the intended logic.
</issue_to_address>
### Comment 2
<location> `TMessagesProj/src/main/java/tw/nekomimi/nekogram/NekoConfig.java:52` </location>
<code_context>
public static ConfigItem useCustomEmoji = addConfig("useCustomEmoji", configTypeBool, false);
public static ConfigItem repeatConfirm = addConfig("repeatConfirm", configTypeBool, false);
public static ConfigItem disableInstantCamera = addConfig("DisableInstantCamera", configTypeBool, false);
+ public static ConfigItem hideInstantCamera = addConfig("HideInstantCamera", configTypeBool, false);
public static ConfigItem showSeconds = addConfig("showSeconds", configTypeBool, false);
</code_context>
<issue_to_address>
**nitpick:** Config key naming is inconsistent with other keys.
Please update "HideInstantCamera" to match the naming style of other config keys for consistency.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
TMessagesProj/src/main/java/org/telegram/ui/Components/ChatAttachAlertPhotoLayout.java
Outdated
Show resolved
Hide resolved
TMessagesProj/src/main/java/tw/nekomimi/nekogram/NekoConfig.java
Outdated
Show resolved
Hide resolved
Co-authored-by: People-11 <41558215+People-11@users.noreply.github.com>
omg-xtao
approved these changes
Oct 28, 2025
BraveSail
added a commit
to BraveSail/Nagram
that referenced
this pull request
Oct 31, 2025
feat: Hide Instant Camera (NextAlone#57)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Introduce a new 'Hide Instant Camera' setting and apply it throughout the photo attachment layout to hide the instant camera cell and preview when enabled.
New Features:
Enhancements: