Skip to content

chore: Remove disabled online status. #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
omg-xtao merged 2 commits into from
Apr 16, 2025
Merged

chore: Remove disabled online status. #52

omg-xtao merged 2 commits into from
Apr 16, 2025

Conversation

@cinitdev
Copy link
Contributor

@cinitdev cinitdev commented Apr 15, 2025 •
edited by sourcery-ai bot
Loading

Summary by Sourcery

Remove disabled online status feature and replace it with a more comprehensive Ghost Mode implementation

New Features:

  • Introduced a new Ghost Mode feature that allows granular control over sending online status, read receipts, typing indicators, and other network-related packets

Enhancements:

  • Refactored online status and read receipt handling to provide more flexible privacy controls
  • Added ability to automatically go offline after sending a message
  • Implemented option to mark messages as read after sending

Chores:

  • Removed legacy disabled status update configuration
  • Cleaned up unused configuration options related to online status

@sourcery-ai
Copy link

sourcery-ai bot commented Apr 15, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request introduces a 'Ghost Mode' feature, allowing users to hide their online status and read receipts. It involves changes to settings, network requests, and UI components to control the visibility of user activity.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Introduces a ghost mode feature that allows users to hide their online status and read receipts.
  • Added settings to control sending read message packets, online status, typing indicators, and story read status.
  • Added an option to automatically go offline after sending a message.
  • Added an option to mark messages as read after sending a message.
  • Added a toggle in the drawer to enable/disable ghost mode.
  • Introduced a new settings screen for configuring ghost mode options.
 TMessagesProj/src/main/java/org/telegram/tgnet/ConnectionsManager.java
TMessagesProj/src/main/java/tw/nekomimi/nekogram/NekoConfig.java
TMessagesProj/src/main/java/org/telegram/ui/Adapters/DrawerLayoutAdapter.java
TMessagesProj/src/main/java/org/telegram/messenger/MessagesController.java
TMessagesProj/src/main/java/tw/nekomimi/nekogram/settings/BaseNekoSettingsActivity.java
TMessagesProj/src/main/java/tw/nekomimi/nekogram/NekoXConfig.java
TMessagesProj/src/main/java/tw/nekomimi/nekogram/settings/NekoXSettingActivity.java
TMessagesProj/src/main/res/values-zh-rCN/strings_na.xml
TMessagesProj/src/main/res/values/strings_na.xml
TMessagesProj/src/main/java/org/telegram/ui/LaunchActivity.java
TMessagesProj/src/main/java/tw/nekomimi/nekogram/settings/NekoExperimentalSettingsActivity.java
TMessagesProj/src/main/java/tw/nekomimi/nekogram/settings/NekoGhostModeActivity.java
TMessagesProj/src/main/java/tw/nekomimi/nekogram/utils/AyuGhostUtils.java
TMessagesProj/src/main/res/drawable/icon_ghost.xml
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Apr 15, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cinitdev - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The introduction of AyuGhostUtils seems reasonable, but ensure it's thoroughly tested and doesn't introduce unexpected side effects elsewhere.
  • Consider adding a settings screen for the ghost mode feature to allow users to easily toggle it on/off.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@omg-xtao omg-xtao self-requested a review April 16, 2025 03:52
@omg-xtao omg-xtao merged commit 1e676ae into NextAlone:dev Apr 16, 2025
5 checks passed
People-11 pushed a commit to People-11/Nagram that referenced this pull request Apr 16, 2025
@cinitdev @People-11
chore: Remove disabled online status. (NextAlone#52)
32bf97b
People-11 pushed a commit to People-11/Nagram that referenced this pull request Apr 16, 2025
@cinitdev @People-11
chore: Remove disabled online status. (NextAlone#52)
f2f9c5e
People-11 pushed a commit to People-11/Nagram that referenced this pull request Apr 16, 2025
@cinitdev @People-11
chore: Remove disabled online status. (NextAlone#52)
b6adfea
People-11 pushed a commit to People-11/Nagram that referenced this pull request Apr 16, 2025
@cinitdev @People-11
chore: Remove disabled online status. (NextAlone#52)
0d30ed2
People-11 pushed a commit to People-11/Nagram that referenced this pull request Apr 16, 2025
@cinitdev @People-11
chore: Remove disabled online status. (NextAlone#52)
48287f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@omg-xtao omg-xtao omg-xtao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cinitdev @omg-xtao