feat: Add integration of Arbitrum precompiles with EVM (with ArbInfo example)#24
Merged
Conversation
…um.Tests in favor of Nethermind.Arbitrum.Test
16 tasks
damian-orzechowski
requested changes
Jun 12, 2025
wurdum
reviewed
Jun 12, 2025
wurdum
approved these changes
Jun 16, 2025
AnkushinDaniil
approved these changes
Jun 17, 2025
AnkushinDaniil
left a comment
Collaborator
There was a problem hiding this comment.
Great job!
I don't have much context on this, but I have a few questions:
- Should gas be burned before expensive operations?
- Should introduced code be thread-safe?
Feel free to merge this PR and address these questions later.
Collaborator
Author
|
Collaborator
Currently I think there is not need for that as there is only a single transaction / EVM processing thread. Unless these precompiles are to be executed elsewhere with possible multithreading, then I don't think it's a requirement (for now). |
damian-orzechowski
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please first review #21 as this one is rebased on it.
This PR depends on some changes to the Nethermind client to make the VirtualMachine overridable.
Here is the related PR on the Nethermind repo.