Skip to content

feat: Make EVM, BlockchainBridge and InitializeBlockchain more overridable for precompile integration#8756

Merged
hudem1 merged 3 commits into
feature/arbitrum-setupfrom
hudem1/feat/arbitrum-precompile-integration
Jun 17, 2025
Merged

feat: Make EVM, BlockchainBridge and InitializeBlockchain more overridable for precompile integration#8756
hudem1 merged 3 commits into
feature/arbitrum-setupfrom
hudem1/feat/arbitrum-precompile-integration

Conversation

@hudem1

@hudem1 hudem1 commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

This PR allows to make a few components: the EVM, NethermindApi (blockchainBridge) and InitializeBlockchain, slightly more overridable for precompile integration.

This PR goes in pair with the one for arbitrum precompile integration here.

This looks like many changes, but actually it's mostly renaming the existing VirtualMachine class to VirtualMachineBase class that now gets derived by a new VirtualMachine class. And I had to change many references now pointing to the base VirtualMachineBase class.

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Small changes to allow for more override of components (for custom precompile integration)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

Comment thread src/Nethermind/Nethermind.Api/NethermindApi.cs
Comment thread src/Nethermind/Nethermind.Evm/VirtualMachine.cs Outdated
Comment thread src/Nethermind/Nethermind.Init/Steps/InitializeBlockchain.cs
@hudem1 hudem1 force-pushed the hudem1/feat/arbitrum-precompile-integration branch from 0c7bbb3 to 7aadd6a Compare June 14, 2025 07:57

@AnkushinDaniil AnkushinDaniil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution!

@hudem1 hudem1 merged commit e3f841b into feature/arbitrum-setup Jun 17, 2025
120 of 122 checks passed
@hudem1 hudem1 deleted the hudem1/feat/arbitrum-precompile-integration branch June 17, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants