feat: Make EVM, BlockchainBridge and InitializeBlockchain more overridable for precompile integration#8756
Merged
hudem1 merged 3 commits intoJun 17, 2025
Conversation
…dable for precompile integration
asdacap
reviewed
Jun 10, 2025
asdacap
reviewed
Jun 10, 2025
asdacap
reviewed
Jun 10, 2025
asdacap
approved these changes
Jun 10, 2025
wurdum
approved these changes
Jun 10, 2025
tanishqjasoria
approved these changes
Jun 10, 2025
…mpile-integration
…() to IVirtualMachine
0c7bbb3 to
7aadd6a
Compare
LukaszRozmej
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows to make a few components: the EVM, NethermindApi (blockchainBridge) and InitializeBlockchain, slightly more overridable for precompile integration.
This PR goes in pair with the one for arbitrum precompile integration here.
This looks like many changes, but actually it's mostly renaming the existing
VirtualMachineclass toVirtualMachineBaseclass that now gets derived by a newVirtualMachineclass. And I had to change many references now pointing to the baseVirtualMachineBaseclass.What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.