Skip to content

feat: Nitro's OpGasPrice opcode#127

Merged
hudem1 merged 7 commits into
mainfrom
hudem1/feat/gas-hook/op-gas-price
Aug 18, 2025
Merged

feat: Nitro's OpGasPrice opcode#127
hudem1 merged 7 commits into
mainfrom
hudem1/feat/gas-hook/op-gas-price

Conversation

@hudem1

@hudem1 hudem1 commented Aug 2, 2025

Copy link
Copy Markdown
Collaborator

See nitro

Need to make opcodes in NMC's VM overridable, see PR there.

Comment thread src/Nethermind.Arbitrum/Evm/ArbitrumEvmInstructions.Environment.cs Outdated
Comment thread src/Nethermind.Arbitrum.Test/Execution/ArbitrumTransactionProcessorTests.cs Outdated
Comment thread src/Nethermind.Arbitrum.Test/Execution/ArbitrumTransactionProcessorTests.cs Outdated
Comment thread src/Nethermind.Arbitrum/Evm/ArbitrumEvmInstructions.Environment.cs Outdated
@codecov

codecov Bot commented Aug 18, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.03%. Comparing base (1b15f82) to head (de293b7).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   83.93%   84.03%   +0.10%     
==========================================
  Files          89       90       +1     
  Lines        5123     5150      +27     
  Branches      726      732       +6     
==========================================
+ Hits         4300     4328      +28     
+ Misses        823      822       -1     
Flag Coverage Δ
unittests 84.03% <100.00%> (+0.10%) ⬆️
Files with missing lines Coverage Δ
...rbitrum/Evm/ArbitrumEvmInstructions.Environment.cs 100.00% <100.00%> (ø)
.../Nethermind.Arbitrum/Evm/ArbitrumVirtualMachine.cs 29.50% <100.00%> (+7.69%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b15f82...de293b7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hudem1 hudem1 merged commit 85f625a into main Aug 18, 2025
8 checks passed
@hudem1 hudem1 deleted the hudem1/feat/gas-hook/op-gas-price branch August 18, 2025 08:59
AnkushinDaniil pushed a commit that referenced this pull request Aug 18, 2025
* feat: Nitro's OpGasPrice opcode

* fix: Code format

* feat: Override GenerateOpCodes directly instead of PrepareSpecAndOpcodes

* fix: Use WithMaxPriorityFeePerGas and make comment more clear

* fix: Move FreeArbosState init to ExecuteTransaction

* feat: Update nethermind git submodule to latest arbitrum-setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants