feat: Nitro's NonrefundableGas() hook#126
Merged
Merged
Conversation
Merged
16 tasks
wurdum
approved these changes
Aug 4, 2025
AnkushinDaniil
approved these changes
Aug 4, 2025
tanishqjasoria
approved these changes
Aug 7, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
==========================================
+ Coverage 83.42% 83.98% +0.56%
==========================================
Files 84 89 +5
Lines 4875 5140 +265
Branches 691 602 -89
==========================================
+ Hits 4067 4317 +250
- Misses 808 823 +15
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
AnkushinDaniil
pushed a commit
that referenced
this pull request
Aug 18, 2025
* feat: Nitro's NonrefundableGas() hook * fix comments * feat: Update nethermind git submodule to latest arbitrum-setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See NonrefundableGas() in nitro then used in
go-ethereum/core/state_transition.go.Needs to have a small update in NMC to make a function overridable, see NMC PR