Skip to content

Fix genesis post processor have no allocations#9488

Merged
asdacap merged 2 commits into
masterfrom
fix/genesis-loader-post-processor-have-no-allocations
Oct 17, 2025
Merged

Fix genesis post processor have no allocations#9488
asdacap merged 2 commits into
masterfrom
fix/genesis-loader-post-processor-have-no-allocations

Conversation

@asdacap

@asdacap asdacap commented Oct 17, 2025

Copy link
Copy Markdown
Contributor
  • Fix genesis post processor have no access to allocations due to the mis-ordering of chain spec allocations clearing.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • reproducable locally

@stdevMac stdevMac requested a review from LukaszRozmej October 17, 2025 07:20
// SPDX-License-Identifier: LGPL-3.0-only

using System.IO;
using FluentAssertions;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, I'd recommend avoiding a new code with FluentAssertions, as we're stuck with its old version.

@asdacap asdacap force-pushed the fix/genesis-loader-post-processor-have-no-allocations branch from f60664c to 761087f Compare October 17, 2025 09:17
@asdacap asdacap merged commit 7e41221 into master Oct 17, 2025
80 checks passed
@asdacap asdacap deleted the fix/genesis-loader-post-processor-have-no-allocations branch October 17, 2025 10:05
stdevMac pushed a commit that referenced this pull request Oct 19, 2025
* Fix genesis post processor have no allocations

* Fix build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants