Try using stream to avoid large buffers allocations in kestrel#9411
Draft
LukaszRozmej wants to merge 6 commits into
Draft
Try using stream to avoid large buffers allocations in kestrel#9411LukaszRozmej wants to merge 6 commits into
LukaszRozmej wants to merge 6 commits into
Conversation
Contributor
|
RPC requests are failing with these changes. |
Member
Author
|
@marcindsobczak try now |
Contributor
marcindsobczak
left a comment
Contributor
There was a problem hiding this comment.
Looks like a significant improvement, worth to run it on some infra nodes to ensure stability
Member
Author
|
Yeah but it might compromise on some other performance stuff... So not sure if worth it with dotnet 10 around the corner. @benaadams ? |
kamilchodola
added a commit
that referenced
this pull request
Feb 20, 2026
Apply CountingStreamPipeWriter(ctx.Response.Body) change inside the refactored ProcessJsonRpcRequestCoreAsync method that master extracted from the inline request processing block.
2 tasks
kamilchodola
added a commit
that referenced
this pull request
Feb 20, 2026
Head-to-head tests measuring UnflushedBytes (peak internal buffer) during serialization. PipeWriter grows to full response size while StreamPipeWriter stays bounded at ~26 bytes via auto-flush.
2dca372 to
f27fba7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Closes Resolves #
Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.