Separate branch and block processor#8980
Merged
Merged
Conversation
| WaitForCacheClear(); | ||
| IReleaseSpec spec = specProvider.GetSpec(suggestedBlock.Header); | ||
| (CancellationTokenSource? prewarmCancellation, Task? preWarmTask) | ||
| = PreWarmTransactions(suggestedBlock, baseBlock, spec); |
Member
There was a problem hiding this comment.
Pre-warming is per-block it is weird it ended up in Branch part
Contributor
Author
There was a problem hiding this comment.
Yea, its probably better made as wrapper to IBlockProcessor
Member
There was a problem hiding this comment.
Should we do it in this PR? Or have next PR ready before merging this one? Without it, it is hard for me to see it as an upgrade.
Contributor
Author
There was a problem hiding this comment.
Probably next, next PR. Although I won't do anything with prewarmer for now.
6214f02 to
a3828ba
Compare
13eab8b to
603fb6d
Compare
LukaszRozmej
approved these changes
Jul 18, 2025
LukaszRozmej
left a comment
Member
There was a problem hiding this comment.
waiting for that next PR
a3828ba to
50eb2bc
Compare
603fb6d to
e8b5c4e
Compare
7 tasks
50eb2bc to
823b270
Compare
e8b5c4e to
c2e847b
Compare
benaadams
reviewed
Jul 23, 2025
| } | ||
| } | ||
|
|
||
| // TODO: move to block processing pipeline |
Member
There was a problem hiding this comment.
Is this TODO to move it back 🤔
Contributor
Author
There was a problem hiding this comment.
Yea, I just copy it. Not sure what does it suppose to be.
tanishqjasoria
approved these changes
Jul 25, 2025
823b270 to
d4b992c
Compare
Member
|
Conflicts |
c2e847b to
9295fce
Compare
emlautarom1
approved these changes
Jul 28, 2025
emlautarom1
left a comment
Contributor
There was a problem hiding this comment.
LGTM. There are probably some unused imports that we could remove here and there though.
| if (_logger.IsTrace) _logger.Trace($"Restored the branch checkpoint - {branchingPointHeader?.ToString(BlockHeader.Format.Short)} | {_stateProvider.StateRoot}"); | ||
| } | ||
|
|
||
| // TODO: block processor pipeline |
Co-authored-by: Lautaro Emanuel <31224949+emlautarom1@users.noreply.github.com>
…k-processor' into feature/separate-branch-and-block-processor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IBlockProcessorintoIBranchProcessor.BranchProcessor) is outside, which resolve some double world scoping.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing